Skip to content

[18.0][REMOVE] budget_control_*: remove _budget_analytic_field and _analytic_tag_field_name #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

Saran440
Copy link
Collaborator

@Saran440 Saran440 commented Jun 20, 2025

  • Move _convert_analytics to budget.docline.mixin.base
  • Remove _budget_analytic_field and _analytic_tag_field_name because all module use same name

@Saran440 Saran440 marked this pull request as ready for review June 20, 2025 10:28
@Saran440
Copy link
Collaborator Author

Hi @kittiu, @ps-tubtim, @newtratip, @ru3ix-bbb,
some modules you are maintaining are being modified, check this out!

@Saran440 Saran440 force-pushed the 18.0-fix-budget_control-move_function branch 3 times, most recently from 7e19b1f to e39a2fb Compare June 21, 2025 04:01
@Saran440 Saran440 force-pushed the 18.0-fix-budget_control-move_function branch from e39a2fb to 4d8f6d3 Compare June 21, 2025 04:08
@Saran440
Copy link
Collaborator Author

/ocabot merge patch

@Saran440
Copy link
Collaborator Author

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-529-by-Saran440-bump-patch, awaiting test results.

@Saran440 Saran440 merged commit 308cc6a into 18.0 Jun 21, 2025
6 checks passed
@Saran440
Copy link
Collaborator Author

Congratulations, your PR was merged at e3d0e4a. Thanks a lot for contributing to ecosoft-odoo. ❤️

@Saran440 Saran440 deleted the 18.0-fix-budget_control-move_function branch June 21, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant