Some components, a layout and a landing page#479
Closed
SeanDylan1982 wants to merge 1590 commits intoecronix:masterfrom
SeanDylan1982:master
Closed
Some components, a layout and a landing page#479SeanDylan1982 wants to merge 1590 commits intoecronix:masterfrom SeanDylan1982:master
SeanDylan1982 wants to merge 1590 commits intoecronix:masterfrom
SeanDylan1982:master
Conversation
Remove Material UI packages & components from Bootstrap shell
Fix project structure and begin with bootstrap like menu
Update rmw-shell dependencies
Updated dependencies in b-shell
Updated dependencies in firebase functions tools
Fixes a minor typo of the word `style` that may very well update some actual styles in a div.
fix: typo to the style prop in a div
aabedraba
force-pushed
the
master
branch
8 times, most recently
from
332ac92 to
b74cf16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 components 3 column layout and landing page
Components
Photo Album
Autocomplete Search bar
Business Card
Links
Members/Friends
3 Column Home layout
Landing page with 8 blocks for shortcuts
This is the second pull request I've ever made and I'm still learning code, nevermind React or Open Source Contributions, so I'm not sure that I've done this right.
I thought the new landing page would have displayed when I created a test app but it was the same one, but I have included the new landing page option in both src folders in the cra-template and the other one.
If someone could point out where I'm going wrong I'd be super grateful 🙏