Skip to content

Conversation

@pca006132
Copy link
Contributor

@pca006132 pca006132 commented Nov 16, 2025

Depends on #267. I split the changes into commits, so it should be slightly simpler to read. That said, I am not sure if the commits are independently compilable. I did not spend time on that.

This is mainly for the async dao, which should improve download performance; at least things should not crash. That said, I also changed things like the API for downloading songs, since I noticed a lot of duplication there.

Note that I haven't yet tested this much, cuz this is rebased from elsewhere. Will need some time to do that.

Also, AutomotiveRepository is not fixed. I don't see an easy way to make this async:

override fun onAddMediaItems(
mediaSession: MediaSession,
controller: MediaSession.ControllerInfo,
mediaItems: List<MediaItem>
): ListenableFuture<List<MediaItem>> {
return super.onAddMediaItems(
mediaSession,
controller,
MediaBrowserTree.getItems(mediaItems)
)
}

@pca006132 pca006132 marked this pull request as ready for review November 16, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant