refactor for async dao #270
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #267. I split the changes into commits, so it should be slightly simpler to read. That said, I am not sure if the commits are independently compilable. I did not spend time on that.
This is mainly for the async dao, which should improve download performance; at least things should not crash. That said, I also changed things like the API for downloading songs, since I noticed a lot of duplication there.
Note that I haven't yet tested this much, cuz this is rebased from elsewhere. Will need some time to do that.
Also,
AutomotiveRepositoryis not fixed. I don't see an easy way to make this async:tempus/app/src/tempus/java/com/cappielloantonio/tempo/service/MediaLibraryServiceCallback.kt
Lines 364 to 374 in 6698052