chore(ci): add rustfmt checks and fix format issues (#40)

Signed-off-by: Lorenzo Delgado <[email protected]>

.github/workflows/ci.yml

@@ -2,8 +2,7 @@ name: ci
 on:
   pull_request:
   push:
-    branches:
-      - "main"
+    branches: [ main ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -26,16 +25,30 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
         with:
           toolchain: stable
-          components: rustfmt, clippy
-          profile: minimal
-          override: true
+          components: clippy
 
-      - name: Cache Cargo build files
+      - name: Cache rust build files
         uses: Leafwing-Studios/cargo-cache@c7e8aa40ae2c975774d3bd766beb92927cfd7771 # v1
 
-      - run: cargo check
-      - run: cargo fmt --all -- --check
-      - run: cargo clippy -- -D warnings
+      - name: check (release)
+        run: cargo check --workspace --all-targets --all-features --release
 
-      - name: Unit tests
-        run: cargo test --lib
+      - name: clippy
+        run: cargo clippy --workspace --all-targets --all-features -- -D warnings --force-warn deprecated --force-warn dead-code
+
+      - name: unit-tests
+        run: cargo test --all-features --lib
+
+  format:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4
+
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@nightly
+        with:
+          toolchain: nightly
+          components: rustfmt
+
+      - run: cargo +nightly fmt --all -- --check

candidate-selection/src/lib.rs

@@ -2,10 +2,11 @@ pub mod num;
 #[cfg(test)]
 mod test;
 
-pub use crate::num::Normalized;
 pub use arrayvec::ArrayVec;
 use ordered_float::NotNan;
 
+pub use crate::num::Normalized;
+
 pub trait Candidate {
     type Id: Eq + Ord;
     fn id(&self) -> Self::Id;

candidate-selection/src/test.rs

@@ -1,6 +1,7 @@
-use crate::{select, ArrayVec, Candidate, Normalized};
 use proptest::{prelude::prop, prop_assert_eq, prop_compose, proptest};
 
+use crate::{select, ArrayVec, Candidate, Normalized};
+
 #[derive(Debug)]
 struct TestCandidate {
     id: u8,

indexer-selection/src/lib.rs

@@ -2,15 +2,16 @@ mod performance;
 #[cfg(test)]
 mod test;
 
-pub use candidate_selection::{ArrayVec, Normalized};
-use custom_debug::CustomDebug;
-pub use performance::*;
 use std::{
     collections::hash_map::DefaultHasher,
     f64::consts::E,
     fmt::Display,
     hash::{Hash as _, Hasher as _},
 };
+
+pub use candidate_selection::{ArrayVec, Normalized};
+use custom_debug::CustomDebug;
+pub use performance::*;
 use thegraph_core::types::{alloy_primitives::Address, DeploymentId};
 use url::Url;
 

indexer-selection/src/test.rs

@@ -1,9 +1,11 @@
-use crate::*;
+use std::ops::RangeInclusive;
+
 use candidate_selection::{num::assert_within, Candidate as _};
 use proptest::{prop_assert, prop_compose, proptest};
-use std::ops::RangeInclusive;
 use thegraph_core::types::alloy_primitives::{hex, FixedBytes};
 
+use crate::*;
+
 #[test]
 fn candidate_should_use_url_display_for_debug() {
     let expected_url = "https://example.com/candidate/test/url";

rust-toolchain.toml

@@ -0,0 +1,3 @@
+[toolchain]
+channel = "stable"
+profile = "default"

rustfmt.toml

@@ -0,0 +1,4 @@
+unstable_features = true
+imports_granularity = "Crate"
+group_imports = "StdExternalCrate"
+reorder_modules = true