Add support for PostGIS types #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Dec 5, 2024
| @@ -82,11 +82,17 @@ jobs: | |||
| with: | |||
| instance-name: test | |||
| server-version: ${{ matrix.edgedb-version }} | |||
| cli-version: ${{ matrix.edgedb-version == 'nightly' && 'nightly' || 'stable' }} | |||
packages/driver/src/cli.mts
Outdated
| @@ -341,6 +341,7 @@ async function downloadFile(url: string | URL, path: string) { | |||
| throw new Error(` - Download failed: ${response.statusText}`); | |||
| } | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
Can we use @ts-expect-error Some note about why here? We have a lint rule for this, but I wonder if the .mts extension is throwing off the matcher. I'll take a look at that.
There was a problem hiding this comment.
I have no idea why that was there. It seems to be fine without it now.
| @@ -197,6 +197,14 @@ export class WriteBuffer { | |||
| return this; | |||
| } | |||
|
|
|||
| writeDeferredSize(): () => void { | |||
There was a problem hiding this comment.
This was just so I didn't need to create a new WriteBuffer to encode the geometry into, only to then immediately copy it into the main message write buffer.
dnwpark
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.