Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add nuxt template settings #875

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tahul
Copy link

@Tahul Tahul commented Feb 22, 2024

Adds a base of recipe for Nuxt that implements auth and basic blogpost features.

Can be tested by running the create CLI locally using Nuxt template.

I'm not sure about what is expected for such create template, feel free to trim anything extraneous.

@edgedb-cla
Copy link

edgedb-cla bot commented Feb 22, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

packages/create/src/recipes/nextjs/index.ts Outdated Show resolved Hide resolved
packages/create/src/recipes/nuxt/index.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,38 @@
using extension auth;

module default {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think we should have these recipes be starting point for any kind of app, not really an example app, if that makes sense. I'd expect that the schema here is empty, and that we add the auth extension here conditionally based on options set by the user.

To that end, if you want to design a small single page that just scaffolds some very basic layout and styles, definitely do that. Probably something closer to https://github.com/nuxt/starter/tree/v3 .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds great.

I started doing the "most minimal" Nuxt starter, but for Nuxt it just looks like adding nuxt-edgedb-module to their modules array.

The rest of it is just described in nuxt-edgedb-module.

Should I push that instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you here.

I'm not sure I understand the question but what I expect to see in these recipes is a totally empty default.esdl file, not even including the using extension auth; expression even. No migrations, no query builder code generator output, etc. These recipes should represent how you'd start day 0 on a new project, not as an example project, if that makes sense. The UI/app itself should also be minimal so that developers can quickly check that everything is working right, but nothing else.

Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants