Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix malicious join test #3439

Merged
merged 1 commit into from
Oct 17, 2024
Merged

e2e: fix malicious join test #3439

merged 1 commit into from
Oct 17, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 17, 2024 •
edited
Loading

Context

For some reason, the IssueJoinTicket returns a nil response now in a failure case, while it seemed not to do so a while ago(?).

Proposed change(s)

  • Only log after getting the response, where (res != nil) == true.

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Oct 17, 2024
@msanft msanft added this to the v2.20.0 milestone Oct 17, 2024
@msanft msanft requested a review from 3u13r as a code owner October 17, 2024 11:26
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 807426b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6710f462f337350008cee7fb

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
e2e/malicious-join 0.00% 0.00% 🚧

@msanft msanft merged commit 0453f5b into main Oct 17, 2024
19 checks passed
@msanft msanft deleted the msanft/e2e/malicious-join-fix branch October 17, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msanft @daniel-weisse