terraform: upgrade hashicorp/google to 6.7.0 #3440
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
burgerdev
force-pushed
the
burgerdev/gcp-iam
branch
from
d594319 to
d1ca6c7
Compare
|
All tests passed! |
| "zh:a66bfc55856693fe82a81554abf7fd72b8ca2d56a08cb59c4769c15b1a1acea5", | ||
| "zh:a8b242c5aab000f2a27e934930a75656efb4a96fdb06a419b22ae0daffa6fba3", | ||
| "zh:da9e9b40d632f218a3e0bb88b8cf95b91485cee1eb2fd2a384d45c2619c36da4", | ||
| "h1:2R/lqkaJ6+JzXLvMjV9RpS800/D+JBVJdUr5cMTCtqA=", |
There was a problem hiding this comment.
This looks like not all hashes for all platform were generated. When a Terraform provider is upgraded by renovate we have one of the ci jobs fixing the hashes I think. Let me see if I can find an example PR.
There was a problem hiding this comment.
I believe //:generate should complain in that case, no?
There was a problem hiding this comment.
Actually, I think all is fine: we're explicitly locking 5 platforms, which should explain the h1 hashes, and the zh hashes are for all assets in the release.
There was a problem hiding this comment.
Ah I guess we loose 5 because we are not using google-beta anymore. That leaves me with 1 unaccounted hash but generally looks good.
There was a problem hiding this comment.
Which hash would that be?
There was a problem hiding this comment.
No idea how they map to the provider binaries, but I count 11 h1 hashes on the left side and 5 on the right.
There was a problem hiding this comment.
Interestingly, we only had 11 h1 hashes for a few months, and even without google-beta: bdfb74f#diff-0c5774419575b03d643fef6eb386884b3871958bacb6950c1ea473bdfaaf054c.
I don't intend to pursue this any further, as mentioned above I think 5 h1 hashes is all we need.
|
Let's hold this back until after the v2.19.0 release. |
Context
CI jobs have been running into GCP IAM inconsistencies, which are caused by a bad waiting condition in the Google Terraform provider. The issue has been fixed, but not backported to 5.x.
Proposed change(s)
Related issue
Additional info
Checklist