Skip to content

Conversation

@burgerdev
Copy link
Member

Context

Golang builds use a module proxy to fetch dependencies. The default configuration is GOPROXY=https://proxy.golang.org,direct, which means "always use proxy.golang.org, and fall back to direct if the result is a 404". If the proxy fails differently (network disconnect, 502, ...), fetching fails.

Proposed change(s)

  • Use fallbacks on all proxy errors (this is done by using | instead of ,).
  • Add goproxy.io as additional fallback.

Related issue

  • Fixes edgelesssys/issues#1004

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Oct 23, 2024
@burgerdev burgerdev added this to the v2.20.0 milestone Oct 23, 2024
@burgerdev burgerdev requested a review from msanft October 23, 2024 12:21
@netlify
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 92e9e65
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6718ea3addb3f700089cdcb0

@burgerdev
Copy link
Member Author

Unit test was successful.

@burgerdev burgerdev merged commit cbd8cc6 into main Oct 23, 2024
9 checks passed
@burgerdev burgerdev deleted the burgerdev/goproxy branch October 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Change won't be listed in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants