-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bare-metal GPU runtime class #1135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 10, 2025 15:21
2218242
to
5bfe77f
Compare
msanft
force-pushed
the
msanft/gpu-image
branch
3 times, most recently
from
January 13, 2025 07:39
98169fc
to
df4e08e
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
2 times, most recently
from
January 13, 2025 08:30
fa64242
to
8674ee5
Compare
msanft
force-pushed
the
msanft/gpu-image
branch
from
January 14, 2025 08:01
df4e08e
to
74a8665
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
3 times, most recently
from
January 14, 2025 08:26
2c70c4e
to
1f69236
Compare
msanft
force-pushed
the
msanft/gpu-image
branch
from
January 17, 2025 15:14
74a8665
to
93683c8
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 17, 2025 15:17
1f69236
to
acf8e0a
Compare
msanft
force-pushed
the
msanft/gpu-image
branch
from
January 17, 2025 16:37
93683c8
to
56b29b3
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
2 times, most recently
from
January 20, 2025 10:03
fe591c1
to
eb8de6c
Compare
burgerdev
reviewed
Jan 20, 2025
packages/by-name/kata/contrast-node-installer-image/package.nix
Outdated
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 20, 2025 12:25
eb8de6c
to
64bba4f
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 20, 2025 12:27
64bba4f
to
3a5d4bc
Compare
burgerdev
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, besides the diff in contrast-node-install.json
.
packages/by-name/kata/contrast-node-installer-image/package.nix
Outdated
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/gpu-image
branch
from
January 22, 2025 09:34
c87ddf9
to
2771f21
Compare
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
3 times, most recently
from
January 22, 2025 09:38
9afca0a
to
0a1f4fa
Compare
katexochen
reviewed
Jan 22, 2025
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 22, 2025 15:20
0a1f4fa
to
b5f9a13
Compare
This adds a runtime class for the local just-based deployments as well as the release artifacts that corresponds to the GPU-enabled runtime for Contrast on bare-metal platforms.
msanft
force-pushed
the
msanft/gpu-runtime-class
branch
from
January 22, 2025 15:24
b5f9a13
to
5255d32
Compare
katexochen
approved these changes
Jan 22, 2025
This adds an E2E test for GPU use on Contrast. It currently runs on the GPU-enabled bare-metal SNP runner. The test currently only verifies that the GPU is available via nvidia-smi, which also verifies that driver and CUDA work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a runtime class for the local just-based deployments as well as the release artifacts that corresponds to the GPU-enabled runtime for Contrast on bare-metal platforms.