Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare-metal GPU runtime class #1135

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jan 10, 2025

This adds a runtime class for the local just-based deployments as well as the release artifacts that corresponds to the GPU-enabled runtime for Contrast on bare-metal platforms.

@msanft msanft added the no changelog PRs not listed in the release notes label Jan 10, 2025
@msanft msanft requested a review from katexochen as a code owner January 10, 2025 10:40
@msanft msanft added this to the v1.4.0 milestone Jan 10, 2025
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 2218242 to 5bfe77f Compare January 10, 2025 15:21
@msanft msanft force-pushed the msanft/gpu-image branch 3 times, most recently from 98169fc to df4e08e Compare January 13, 2025 07:39
@msanft msanft force-pushed the msanft/gpu-runtime-class branch 2 times, most recently from fa64242 to 8674ee5 Compare January 13, 2025 08:30
@msanft msanft requested a review from burgerdev January 13, 2025 10:46
@msanft msanft force-pushed the msanft/gpu-runtime-class branch 3 times, most recently from 2c70c4e to 1f69236 Compare January 14, 2025 08:26
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 1f69236 to acf8e0a Compare January 17, 2025 15:17
@msanft msanft force-pushed the msanft/gpu-runtime-class branch 2 times, most recently from fe591c1 to eb8de6c Compare January 20, 2025 10:03
justfile Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from eb8de6c to 64bba4f Compare January 20, 2025 12:25
@msanft msanft requested a review from burgerdev January 20, 2025 12:25
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 64bba4f to 3a5d4bc Compare January 20, 2025 12:27
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, besides the diff in contrast-node-install.json.

@msanft msanft force-pushed the msanft/gpu-runtime-class branch 3 times, most recently from 9afca0a to 0a1f4fa Compare January 22, 2025 09:38
packages/containers.nix Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 0a1f4fa to b5f9a13 Compare January 22, 2025 15:20
@msanft msanft requested a review from katexochen January 22, 2025 15:20
This adds a runtime class for the local just-based deployments as well
as the release artifacts that corresponds to the GPU-enabled runtime for
Contrast on bare-metal platforms.
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from b5f9a13 to 5255d32 Compare January 22, 2025 15:24
This adds an E2E test for GPU use on Contrast.
It currently runs on the GPU-enabled bare-metal SNP runner.

The test currently only verifies that the GPU is available via
nvidia-smi, which also verifies that driver and CUDA work correctly.
@msanft msanft merged commit bff8f81 into msanft/gpu-image Jan 23, 2025
12 checks passed
@msanft msanft deleted the msanft/gpu-runtime-class branch January 23, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants