just: inject imagepuller config #1937
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charludo
force-pushed
the
ch/just-use-registry-auth
branch
4 times, most recently
from
d75f19f to
406e0cc
Compare
katexochen
requested changes
Nov 19, 2025
charludo
force-pushed
the
ch/just-use-registry-auth
branch
from
406e0cc to
24be9f6
Compare
charludo
force-pushed
the
ch/just-use-registry-auth
branch
from
24be9f6 to
5b737e7
Compare
katexochen
reviewed
Nov 19, 2025
charludo
force-pushed
the
ch/just-use-registry-auth
branch
2 times, most recently
from
ea7569f to
f4d8100
Compare
charludo
force-pushed
the
ch/just-use-registry-auth
branch
from
f4d8100 to
434771f
Compare
katexochen
reviewed
Nov 20, 2025
Member
katexochen
left a comment
katexochen
left a comment
There was a problem hiding this comment.
Code lgtm, but I want to test this when the e2e test is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads GH token from GCP, and uses it to create the secrets file in
just populate.We could just store the entire config in gcp, but this way it's easy to adjust and extend with additional configuration.