Conversation
appease linter
burgerdev
commented
Nov 21, 2025
Comment on lines
+47
to
+52
| // The following fields match the fields of userapi.GetManifestsResponse | ||
|
|
||
| Manifests [][]byte // Manifest history, the current manifest being last. | ||
| Policies map[manifest.HexString][]byte // Policies referred to by manifests. | ||
| RootCA []byte // PEM-encoded certificate | ||
| MeshCA []byte // PEM-encoded certificate |
Member
Author
There was a problem hiding this comment.
msanft
approved these changes
Nov 21, 2025
Mention browser use-case Co-authored-by: Moritz Sanft <[email protected]>
thomasten
approved these changes
Nov 21, 2025
| This could be a future _addition_ to the SDK, but is mostly unrelated to the proposal made here. | ||
|
|
||
| As a workaround for now, the history check can be implemented outside the SDK (since it's just a byte-for-byte comparison of slice items). | ||
| This check can be made even simpler if the Contrast deployment is only ever expected to have one manifest in the history (Privatemode.ai, for example). |
Member
There was a problem hiding this comment.
If I --disable-updates, I don't need to check anything myself, right?
Member
Author
There was a problem hiding this comment.
--disable-updates results in a manifest without workload owner keys. However, that state can also be reached by just setting a manifest without workload owner keys on an existing coordinator history. If you care about that (which you only need to if you're relying on workload secrets, imho), you should validate that the history has only one manifest.
katexochen
reviewed
Nov 21, 2025
katexochen
approved these changes
Nov 21, 2025
charludo
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/edgelesssys/contrast/blob/rfc/012/rfc/012-application-level-verification.md