fix env var from host truncated at equal sign#271
Merged
Conversation
✅ Deploy Preview for ego-docs canceled.
|
daniel-weisse
approved these changes
Apr 24, 2024
ego/premain/core/core.go
Outdated
Comment on lines
54
to
55
| splitString := strings.SplitN(envVar, "=", 2) | ||
| hostEnvironMap[splitString[0]] = splitString[1] |
Member
There was a problem hiding this comment.
Suggested change
| splitString := strings.SplitN(envVar, "=", 2) | |
| hostEnvironMap[splitString[0]] = splitString[1] | |
| envName, envValue, _ := strings.Cut(envVar, "=") | |
| hostEnvironMap[envName] = envValue |
The Go docs recommend using Cut if splitting around the first instance of a separator.
There shouldn't be any functional difference though
thomasten
force-pushed
the
fix-envvar-equalsign
branch
from
11d00b6 to
d8a2d7a
Compare
thomasten
force-pushed
the
fix-envvar-equalsign
branch
from
d8a2d7a to
d1dbb51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOO=bar=bazwas truncated to the valuebar