Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Multiple toolbox items (new solution) #80

Merged
merged 1 commit into from
May 18, 2022

Conversation

neSpecc
Copy link
Contributor

@neSpecc neSpecc commented May 17, 2022

This PR is a proposal solution to the #79.

I would suggest using data overrides instead of config overrides in the toolbox property.

It allows:

  • to get rid of activeToolboxEntry getter (it could be matched by current block data)
  • to not to force developers for using config
  • to allow developers to override any Block properties via multiple toolbox items. For example, set predefined texts and so on.
  • the data is supposed to be supported in rendering already

@neSpecc neSpecc changed the base branch from master to feat/vertical-toolbox-multiple-items May 17, 2022 19:27
@neSpecc neSpecc merged commit 599c6b7 into feat/vertical-toolbox-multiple-items May 18, 2022
@neSpecc neSpecc deleted the pr-79-data-way branch May 18, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants