chore: enhance TypeScript configuration and build process #284
+351
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amriksingh0786
commented
Feb 8, 2025
amriksingh0786
commented
- Update tsconfig.json with stricter type checking and module resolution
- Modify package.json scripts to include type checking and declaration generation
- Update Vite configuration for better module and library bundling
- Improve type definitions and utility functions
- Add type-related scripts and configuration for better developer experience
- Update tsconfig.json with stricter type checking and module resolution - Modify package.json scripts to include type checking and declaration generation - Update Vite configuration for better module and library bundling - Improve type definitions and utility functions - Add type-related scripts and configuration for better developer experience
neSpecc
reviewed
Feb 8, 2025
neSpecc
requested changes
Feb 8, 2025
src/types/index.d.ts
Outdated
There was a problem hiding this comment.
what is the purpose of this file?
There was a problem hiding this comment.
importing type definitions for the ImageTool module, would be eaiser. I mean user can just import it and he will have all types defined for ImageModule. If they are importing ImageTool in a ts project then it would be seamless. They dont need to worry about defining types.
src/types/types.ts
Outdated
Comment on lines
179
to
184
| byFile: string; | ||
|
|
||
| /** | ||
| * Endpoints for URL upload. | ||
| */ | ||
| byUrl?: string; | ||
| byUrl: string; |
There was a problem hiding this comment.
these fields are optional. At least one should be optional.
- Update default image data initialization in index.ts - Add type documentation for index.d.ts to improve type clarity
- Remove redundant JSDoc comments from type interfaces - Improve inline documentation for type interfaces - Simplify type definitions while preserving their core structure
- Update ImageConfig interface to make byFile property optional - Improve type flexibility for image configuration
- Return upload promise directly instead of resolving immediately - Ensure proper error and success handling for upload methods - Remove redundant Promise.resolve() calls in upload methods
- Improve JSON formatting and readability - Remove redundant library declaration for 'dom' - Maintain existing TypeScript compiler options
- Remove unnecessary rollupOptions configuration for external dependencies - Simplify Vite build configuration - Maintain existing sourcemap and build format settings
neSpecc
reviewed
Feb 14, 2025
src/types/index.d.ts
Outdated
There was a problem hiding this comment.
Type definitions are generated during compilation, we don't need to maintain them manually
There was a problem hiding this comment.
got it, thanks. removed it.
- Convert string quotes from double to single quotes in vite.config.js - Update import statements and string literals in index.ts and ui.ts - Maintain consistent code style and formatting - Improve code readability and consistency
- Add null coalescing for byFile endpoint URL - Improve type casting for additional request data - Ensure type safety when appending form data
- Delete src/types/index.d.ts type declaration file - Remove unnecessary type definitions for ImageTool
neSpecc
reviewed
Feb 14, 2025
src/types/types.ts
Outdated
| @@ -141,7 +140,7 @@ export interface ImageConfig { | |||
| /** | |||
| * Endpoints for URL upload. | |||
| */ | |||
| byUrl?: string; | |||
| byUrl: string; | |||
There was a problem hiding this comment.
byFile and byUrl both are optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.