Conversation
cxw42
left a comment
There was a problem hiding this comment.
In CMakeLists.txt, set_tests_properties, that has to stay PROPERTIES, not be changed to PAIRS. Do the tests pass with these changes? If so, something very strange is happening in cmake land.
|
That's just the thing. I don't think these tests are being tested without an implementation. How do we go about doing that? |
|
I usually test with editorconfig-c and editorconfig-vim. After initializing the submodules, I make sure the old tests pass :) . I then cd into the core-test submodule and checkout the PR. Then I run the tests and see what I get. I could add a Travis/Appveyor setup to run against the vimscript core without too much trouble. I might also be able to do the C core, but that is more challenging on Appveyor because of the Windows build infrastructure. |
|
We should use GitHub Actions. Leave this PR open. I'll figure out the CI. |
As per the specification, we are no longer referring to key-value pairs as properties, but just pairs or key-value pairs.