Set shiftwidth to 0 (defaults to tabstop value)#214
Set shiftwidth to 0 (defaults to tabstop value)#214gwymor wants to merge 1 commit intoeditorconfig:masterfrom
Conversation
|
Thanks for this PR! I remember that when we last touched the sw/ts/sts material there were some corner cases around Tab and Backspace behaviour. What scenarios have you tested with this new code? |
|
I've been using these changes in my Vim configuration for a couple years without issues with any editorconfigs I've come across so far. I don't set If you set I'll fix the merge conflicts and that issue. |
9edac64 to
c7d60a6
Compare
The current behavior is to set both shiftwidth and tabstop/softtabstop. shiftwidth gets set to the same value as tabstop. If I open a file that editorconfig indents with 8-space hard tabs, then ":set tabstop=4", my shiftwidth will still be 8, meaning that when I indent I will get two tabs. Set shiftwidth to 0, which defaults to the value of tabstop, and disable softtabstop so it doesn't conflict. This should have the same end result with less complication. This removes the g:EditorConfig_softtabstop_space and g:EditorConfig_softtabstop_tab options. Users who want to delete multiple spaces as a single character can enable smarttab.
c7d60a6 to
2dcbd4f
Compare
The current behavior is to set both shiftwidth and tabstop/softtabstop.
shiftwidth gets set to the same value as tabstop. If I open a file that
editorconfig indents with 8-space hard tabs, then ":set tabstop=4", my
shiftwidth will still be 8, meaning that when I indent I will get two
tabs. Set shiftwidth to 0, which defaults to the value of tabstop, and
disable softtabstop so it doesn't conflict. This should have the same
end result with less complication.
This removes the g:EditorConfig_softtabstop_space and
g:EditorConfig_softtabstop_tab options. Users who want to delete
multiple spaces as a single character can enable smarttab.