-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Indentation section to document the exact exapected behavior of… #65
Added Indentation section to document the exact exapected behavior of… #65
Conversation
5b1493a
to
431d12d
Compare
Hey @xuhdev, any chance to review the PR soon? We'll soon complete the plugin, we're going to need the clarification to justify the behavior of the plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and thanks for the writeup!
I've made a suggestion to rewrite the bullet point, and some grammatical changes in the indentation section.
Hey @xuhdev! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! I added some comments for minor language and format changes. Other than those, the PR is good to go.
Hey @xuhdev! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! GitHub can also squash merge, do you want me go ahead, or you have something else in mind?
… inedntation realted options
c721436
to
7036714
Compare
No, everything's good. I've squashed the commits to ease the job for you 😄 You can proceed with merging it into the master trunk 😄 |
As discussed in this issue, there turned out to be a lot of undocumented behavior in terms of indentation style in use. This PR aims to address the problem mentioned in the aforementioned issue by documenting the behavior of indentation options.
CC: @xuhdev
📚 Documentation preview 📚: https://editorconfig-specification--65.org.readthedocs.build/