Skip to content

Update sign out to logout for consistency #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sumac/indigo
Choose a base branch
from

Conversation

zubairshakoorarbisoft
Copy link

📄 Description

This PR resolves consistency of Inconsistent navigation across "Profile," "Account," and "Dashboard" pages.

🎯 Issue

Actual Result:
The "Profile," "Account," and "Dashboard" pages have different navigation lists, leading to inconsistency in the user experience. This inconsistency can confuse users and make navigation between pages less intuitive.
image

✅ Fix

Need to update the word from Sign Out to Logout for consistency among all the pages.

🔗 Related

Live Preview: Demo Course – Progress
Taiga Ticket: Inconsistent navigation across "Profile," "Account," and "Dashboard" pages
Related GitHub Issue: overhangio/tutor-indigo#146

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.77%. Comparing base (fedab6c) to head (d625fc1).
Report is 4 commits behind head on sumac/indigo.

Additional details and impacted files
@@              Coverage Diff              @@
##           sumac/indigo      #31   +/-   ##
=============================================
  Coverage         64.77%   64.77%           
=============================================
  Files                49       49           
  Lines               477      477           
  Branches            105      106    +1     
=============================================
  Hits                309      309           
  Misses              165      165           
  Partials              3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahmed-arb
Copy link

I think we should name this option "Sign Out" to align with upstream.

@zubairshakoorarbisoft
Copy link
Author

I think we should name this option "Sign Out" to align with upstream.

As per discussion with QA, we decided it, so that it will be consistent on all the screens. Also this change is also indigo based, so it should change anything related to upstream.

@ahmed-arb
Copy link

With Indigo disabled, this option is consistently labeled as "Sign out" across both legacy and MFE pages. I couldn’t find any rationale for labeling it "Logout" in Indigo's legacy pages.
So wouldn't it be easier to just change the overriding template in Indigo from "Logout" to "Sign out" instead of carrying this change forward into current and future MFEs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants