Skip to content

feat: allow multiple fields to be validated in one intent #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oxc
Copy link

@oxc oxc commented Mar 12, 2025

As suggested by @edmundhung in #830 (comment)

Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: dab55c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@conform-to/dom Minor
@conform-to/react Minor
@conform-to/yup Minor
@conform-to/zod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 12, 2025

Open in Stackblitz

More templates

@conform-to/dom

npm i https://pkg.pr.new/@conform-to/dom@878

@conform-to/react

npm i https://pkg.pr.new/@conform-to/react@878

@conform-to/yup

npm i https://pkg.pr.new/@conform-to/yup@878

@conform-to/validitystate

npm i https://pkg.pr.new/@conform-to/validitystate@878

@conform-to/zod

npm i https://pkg.pr.new/@conform-to/zod@878

commit: dab55c2

Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you help adding an integration test for it? You can update the form-control test with a new button that validate multiple fields and assert if it works properly. Thanks for working on this!

@oxc
Copy link
Author

oxc commented Mar 21, 2025

I've added a test for this case in form-control as you suggested.

@oxc
Copy link
Author

oxc commented Apr 13, 2025

Is anything else required to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants