-
Notifications
You must be signed in to change notification settings - Fork 127
feat: allow multiple fields to be validated in one intent #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dab55c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@conform-to/dom
@conform-to/react
@conform-to/yup
@conform-to/validitystate
@conform-to/zod
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Can you help adding an integration test for it? You can update the form-control test with a new button that validate multiple fields and assert if it works properly. Thanks for working on this!
I've added a test for this case in form-control as you suggested. |
Is anything else required to get this merged? |
As suggested by @edmundhung in #830 (comment)