Skip to content

fix(notes): export notes from library window #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2025
Merged

Conversation

panaC
Copy link
Member

@panaC panaC commented Apr 14, 2025

Fixes #2924

This PR includes:

  • add readiumAnnotation selectors in the INoteState interface
  • selectors are computed after new note creation dispatching and updated as well with the same action
  • selectors compute are executed in the noteAddUpdate saga handler after 100ms delay
  • add a "export notes" button to the publicationCard -> CatalogMenu
    • fetch notes from main process with getAnnotationFromMainWinState (same function as importAnnotation) and use electron streamProtocol streamerNoHTTP
  • call exportAnnotationSet saga function with sagaMiddleware.run
  • fix an issue with the locatorExtended mutability, need to clone it before passing to addUpdateNote action

@panaC panaC self-assigned this Apr 14, 2025
@panaC panaC marked this pull request as ready for review April 17, 2025 15:53
@panaC
Copy link
Member Author

panaC commented Apr 22, 2025

See comment : 7a27e97#commitcomment-155543637

@panaC panaC merged commit fe5dd0f into develop Apr 22, 2025
2 checks passed
@panaC panaC deleted the feat/notesexportfromlib branch April 22, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Export notes from book context menu
2 participants