feat: Add ability to lookup icons by name or slug #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The type of the IconsInfo slice changes to pointer members, to avoid having to maintain multiple copies of the whole icon library in memory for consumers, now that infos are used multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The type of the IconsInfo slice changes to pointer
members, to avoid having to maintain multiple copies of the whole icon
library in memory for consumers, now that infos are used multiple times.
I split the commits with just the code changes in the first commit, and generated content in the second commit, hopefully makes review a little easier.
This would require a v2 release due to the breaking type change on the exported
IconsInfoslice.Fixes #2