-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Configuration and API change #25
Draft
eelregit
wants to merge
17
commits into
master
Choose a base branch
from
conf_refac
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelregit
changed the title
Refactor Cosmology and Configuration, and API change
Refactor Configuration, and API change
Nov 7, 2023
eelregit
changed the title
Refactor Configuration, and API change
Refactor Configuration and API change
Nov 7, 2023
eelregit
force-pushed
the
conf_refac
branch
2 times, most recently
from
November 15, 2023 12:42
421646f
to
6939058
Compare
Distances added |
The units, constants, dtype settings, transfer settings, growth settings, and linear variance settings in Configuration couple more tightly with Cosmology, and are moved there. After that boltzmann.py can also be independent of Configuration, and together with cosmology.py functions like jax-cosmo or other cosmology libraries.
including Cosmology.K, with uppercase K. Omega_k's also changed to Omega_K's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The units, constants, dtype settings, transfer settings, growth settings, and linear variance settings in
Configuration
couple more tightly withCosmology
, and should be moved there. After thatboltzmann.py
can also be independent ofConfiguration
, and functions likejax-cosmo
together withcosmology.py
.Likewise, I also try to make
Particles
more independent of conf. And have some different dtype design forCosmology
andParticles
.To accommodate new features, e.g., sCOLA-like parallelization and observables, the plan is to change the old API
to
Discussions and comments are welcome.