Merge branch '14.0-fix-product_contract-recordset' of git+ssh://githu…

…b.com/efatto/contract into 14.0
efatto · Jan 11, 2025 · 33d4a94 · 33d4a94
2 parents 3158c53 + 90aca03
commit 33d4a94
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/product_contract/models/product_template.py b/product_contract/models/product_template.py
@@ -73,7 +73,13 @@ def write(self, vals):
     @api.constrains("is_contract", "type")
     def _check_contract_product_type(self):
         """
-        Contract product should be service type
+        Contract product should be service type, check by recordset
         """
-        if self.is_contract and self.type != "service":
-            raise ValidationError(_("Contract product should be service type"))
+        for record in self:
+            if record.is_contract and record.type != "service":
+                raise ValidationError(
+                    _(
+                        "Contract product (%(product_name)s) should be service type",
+                        product_name=record.name,
+                    )
+                )