ENH: Add visible close button and unit test #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an 'X' button to the top-right corner of the main window for closing the application. - Adds a unit test verifying the close button triggers application quit. - Updates Qt abstraction layer to ensure QPushButton is available. - Refines test setup with necessary mocks for QApplication.instance.
kernc
force-pushed
the
feature/add-close-button
branch
from
e1f8e19 to
72fe2fa
Compare
kernc
commented
Jul 11, 2025
efck/gui.py
Outdated
| parent=self, | ||
| ) | ||
| close_button.clicked.connect(QApplication.instance().quit) | ||
| close_button.setFixedSize(20, 20) # Small, square button |
Member
Author
There was a problem hiding this comment.
Suggested change
| close_button.setFixedSize(20, 20) # Small, square button | |
| close_button.setFixedSize(20, 20) |
efck/gui.py
Outdated
| ) | ||
| close_button.clicked.connect(QApplication.instance().quit) | ||
| close_button.setFixedSize(20, 20) # Small, square button | ||
| close_button.setStyleSheet("QPushButton { padding: 1px; margin: 4px; }") # Minimal padding and some margin |
Member
Author
There was a problem hiding this comment.
Suggested change
| close_button.setStyleSheet("QPushButton { padding: 1px; margin: 4px; }") # Minimal padding and some margin | |
| close_button.setStyleSheet("QPushButton { padding: 1px; margin: 4px; }") |
kernc
commented
Jul 11, 2025
kernc
added a commit
that referenced
this pull request
Jul 12, 2025
* feat: Add close button and unit test for efck#26 - Adds an 'X' button to the top-right corner of the main window for closing the application. - Adds a unit test verifying the close button triggers application quit. - Updates Qt abstraction layer to ensure QPushButton is available. - Refines test setup with necessary mocks for QApplication.instance. * Revert complex test * Fixup * Update efck/gui.py * Update efck/gui.py --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26