Skip to content

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Oct 19, 2025

No description provided.

Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enable-tegg-plugins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.55%. Comparing base (6443899) to head (4fb64e0).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #5630       +/-   ##
===========================================
+ Coverage   84.72%   98.55%   +13.82%     
===========================================
  Files         565        9      -556     
  Lines       11003      138    -10865     
  Branches     1242       18     -1224     
===========================================
- Hits         9322      136     -9186     
+ Misses       1581        2     -1579     
+ Partials      100        0      -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

QualifierImplDecoratorUtil,
type EggObjectFactory,
type IncomingHttpHeaders,
} from '@eggjs/tegg';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有循环依赖,没法将 tegg 的东西放到 egg 里面导出。
看起来的改成 egg/common 命名空间下,或者 egg/tegg 下。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @killagu 看看有什么命名建议。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先找一下循环依赖在那里,看看能否解决再考虑换命名空间。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant