-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: enable all tegg plugin by defaults #5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5630 +/- ##
===========================================
+ Coverage 84.72% 98.55% +13.82%
===========================================
Files 565 9 -556
Lines 11003 138 -10865
Branches 1242 18 -1224
===========================================
- Hits 9322 136 -9186
+ Misses 1581 2 -1579
+ Partials 100 0 -100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
QualifierImplDecoratorUtil, | ||
type EggObjectFactory, | ||
type IncomingHttpHeaders, | ||
} from '@eggjs/tegg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有循环依赖,没法将 tegg 的东西放到 egg 里面导出。
看起来的改成 egg/common
命名空间下,或者 egg/tegg
下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @killagu 看看有什么命名建议。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我先找一下循环依赖在那里,看看能否解决再考虑换命名空间。
No description provided.