Draft
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate existing codebase to oxlint js plugins
Migrate to oxlint JavaScript plugins support
Oct 10, 2025
Member
|
@copilot should add tests with oxlint |
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Author
Added comprehensive oxlint tests in commit ab0f05f. The test suite includes:
All 23 tests pass (19 original + 4 new oxlint tests). |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds support for oxlint's JavaScript plugin system, making
eslint-plugin-eggachecompatible with both ESLint and oxlint.Changes
Package Metadata
package.jsondescription to mention oxlint compatibilityoxlint,eslint,eslintplugin,eggjs,egg) for better discoverabilityoxlintas dev dependency (v1.22.0)test:oxlintnpm script for oxlint-specific testingPlugin Metadata
metafield to plugin export withnameandversion(required by oxlint's JavaScript plugin loader)Rule Metadata Improvements
Enhanced all three rules (
no-only-tests,no-override-exports,no-unexpected-plugin-keys) with proper metadata:type: 'problem'field to meta section for better linter compatibilityfixablefield inno-only-testsfromtrueto'code'(proper ESLint/oxlint format)Documentation
Updated README.md with comprehensive oxlint support:
Oxlint Tests
Added comprehensive oxlint integration test suite in
test/oxlint/:meta.name,meta.version)meta.type,meta.docs,create).oxlintrc.json) for testing.eslintignoreto exclude test fixtures (they contain intentional violations)Compatibility
The plugin maintains 100% backward compatibility with ESLint while adding full support for oxlint. The existing plugin structure was already ESLint-compliant, requiring only minimal metadata and documentation updates.
Testing
Users can now seamlessly use this plugin with either ESLint or oxlint!
Fixes #7
Original prompt
Fixes #7
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.