feat: add biz handler

app.js

@@ -12,6 +12,8 @@ const {
 } = require('./lib/utils');
 
 module.exports = app => {
+  app.config.coreMiddleware.push('onerrorBizHandler');
+
   // logging error
   const config = app.config.onerror;
   const viewTemplate = fs.readFileSync(config.templatePath, 'utf8');
@@ -43,9 +45,9 @@ module.exports = app => {
 
   const errorOptions = {
     // support customize accepts function
-    accepts() {
+    accepts(...args) {
       const fn = config.accepts || accepts;
-      return fn(this);
+      return fn(this, ...args);
     },
 
     html(err) {

app/middleware/onerror_biz_handler.js

@@ -0,0 +1,51 @@
+'use strict';
+
+const { EggError, ErrorType } = require('egg-errors');
+const { accepts } = require('../../lib/utils');
+
+module.exports = (_, app) => {
+  const application = app.config.onerror.application;
+
+  return async function onerrorBizHandler(ctx, next) {
+    try {
+      await next();
+    } catch (err) {
+      const fn = app.config.onerror.accepts || accepts;
+      const contentType = fn(ctx, 'html', 'text', 'json');
+      console.info(contentType);
+      const type = EggError.getType(err);
+      console.log(type);
+      switch (type) {
+        case ErrorType.ERROR: {
+          ctx.status = err.status || 500;
+          ctx.body = format(err, contentType);
+          break;
+        }
+
+        case ErrorType.EXCEPTION: {
+          ctx.logger.error(err);
+          err.status = 500;
+          ctx.body = format(err, contentType);
+          break;
+        }
+
+        case ErrorType.BUILTIN:
+        default:
+          throw err;
+      }
+    }
+
+    function format(err, contentType) {
+      if (contentType === 'json' && application.formatJSON) {
+        ctx.body = application.formatJSON(err);
+      } else if (contentType === 'text' && application.formatText) {
+        ctx.body = application.formatText(err);
+      } else if (contentType === 'html' && application.formatHtml) {
+        ctx.body = application.formatHtml(err);
+      } else {
+        throw err;
+      }
+    }
+  };
+
+};

config/config.default.js

@@ -11,4 +11,10 @@ exports.onerror = {
   appErrorFilter: null,
   // default template path
   templatePath: path.join(__dirname, '../lib/onerror_page.mustache'),
+  // normalize your error response from error object
+  application: {
+    formatJSON: null,
+    formatText: null,
+    formatHtml: null,
+  },
 };

package.json

@@ -25,6 +25,7 @@
   ],
   "dependencies": {
     "cookie": "^0.3.1",
+    "egg-errors": "^1.0.1",
     "koa-onerror": "^4.0.0",
     "mustache": "^2.3.0",
     "stack-trace": "^0.0.10"

test/fixtures/onerror-biz/app/controller/home.js

@@ -0,0 +1,22 @@
+'use strict';
+
+const { Controller } = require('egg');
+const { EggError, EggException } = require('egg-errors');
+
+
+class HomeController extends Controller {
+  async throwError() {
+    throw new Error('error');
+  }
+
+  async throwEggError() {
+    throw new EggError('egg error');
+  }
+
+  async throwEggException() {
+    throw new EggException('egg exception');
+  }
+
+}
+
+module.exports = HomeController;

test/fixtures/onerror-biz/app/router.js

@@ -0,0 +1,7 @@
+'use strict';
+
+module.exports = app => {
+  app.get('/error', app.controller.home.throwError);
+  app.get('/eggerror', app.controller.home.throwEggError);
+  app.post('/eggexception', app.controller.home.throwEggException);
+};

test/fixtures/onerror-biz/config/config.default.js

@@ -0,0 +1,37 @@
+'use strict';
+
+exports.logger = {
+  level: 'NONE',
+  consoleLevel: 'NONE',
+};
+
+exports.keys = 'foo,bar';
+
+exports.security = {
+  csrf: false,
+};
+
+exports.onerror = {
+  accepts(ctx, ...args) {
+    console.log(ctx.type, ctx.headers);
+    const a = ctx.accepts(...args);
+    console.log(a, ...args);
+    return a;
+  },
+  application: {
+    formatJSON(err) {
+      return {
+        message: err.message,
+        code: err.code,
+        status: err.status,
+        data: err.data,
+      };
+    },
+    formatText(err) {
+      return err.message;
+    },
+    formatHtml(err) {
+      return '<h2>' + err.message + '</h2>';
+    },
+  },
+};

test/fixtures/onerror-biz/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "onerror"
+}

test/onerror.test.js

@@ -473,4 +473,28 @@ describe('test/onerror.test.js', () => {
     });
 
   });
+
+
+  describe.only('biz error', () => {
+    let app;
+    before(() => {
+      app = mm.app({
+        baseDir: 'onerror-biz',
+      });
+      return app.ready();
+    });
+    after(() => app.close());
+
+    it('should format error', async () => {
+      await app.httpRequest()
+        .get('/error')
+        .set('Accept', 'application/json')
+        .expect({
+
+        })
+        .expect(200);
+    });
+
+  });
+
 });