WIP: feat: first implement logger #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Aug 23, 2023
| @@ -0,0 +1,7 @@ | |||
| export interface ILogger { | |||
There was a problem hiding this comment.
ILogger 是不是单独发一个 npm 包？像 layotto js-sdk 其实不感知 tegg 的存在的。
There was a problem hiding this comment.
那是不是把 zlogger 这个库改造下，把 egg-logger 的一些实现放过去
There was a problem hiding this comment.
最好就是纯 interface 定义，这样依赖都可以不添加。https://github.com/layotto/js-sdk/blob/main/src/client/Client.ts#L79
There was a problem hiding this comment.
对啊，正常还是可以依赖一个 logger 的，现在只是没有承载。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change