Skip to content

Update generationtTemplateConfigs.ts #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update generationtTemplateConfigs.ts #1711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions health-services/project-factory/src/server/config/generationtTemplateConfigs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const generationtTemplateConfigs : any = {
{
sheetName: "HCM_ADMIN_CONSOLE_BOUNDARY_DATA",
schemaName: "boundary-data",
lockWholeSheet: true
lockWholeSheet: false
}
Comment on lines 19 to 22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Add a brief comment explaining why these sheets are unlocked

A short rationale (e.g., “allow admins to edit boundary data inline”) helps avoid future toggles back to true during refactors.

Apply this minimal inline comment near each change:

   {
     sheetName: "HCM_ADMIN_CONSOLE_BOUNDARY_DATA",
     schemaName: "boundary-data",
-    lockWholeSheet: false
+    lockWholeSheet: false // Intentionally unlocked to allow inline boundary data edits
   }

Also applies to: 46-49

🤖 Prompt for AI Agents 
In
health-services/project-factory/src/server/config/generationtTemplateConfigs.ts
around lines 19-22 (and similarly for lines 46-49), the objects set
lockWholeSheet: false lack an explanatory comment; add a concise inline comment
next to each lockWholeSheet: false (e.g., “// allow admins to edit boundary data
inline” or appropriate domain-specific reason) so future readers understand why
the sheet is intentionally unlocked.

],
},
Expand All @@ -45,7 +45,7 @@ export const generationtTemplateConfigs : any = {
{
sheetName: "HCM_ADMIN_CONSOLE_BOUNDARY_DATA",
schemaName: "boundary-data",
lockWholeSheet: true
lockWholeSheet: false
}
],
},
Expand Down
Loading