Skip to content

Commit

Permalink
Swap the order of the CKF algorithm arguments (#1640)
Browse files Browse the repository at this point in the history
Minor code clean up.

The order of the CKF algorithm arguments has been swapped around to
match the order provided to the factory generator making it slightly
easier to follow the code.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [x] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No
### Does this PR change default behavior?
No
  • Loading branch information
simonge authored Oct 23, 2024
1 parent 7251aaf commit 5e39885
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/algorithms/tracking/CKFTracking.cc
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ namespace eicrecon {
std::vector<ActsExamples::Trajectories*>,
std::vector<ActsExamples::ConstTrackContainer*>
>
CKFTracking::process(const edm4eic::Measurement2DCollection& meas2Ds,
const edm4eic::TrackParametersCollection &init_trk_params) {
CKFTracking::process(const edm4eic::TrackParametersCollection& init_trk_params,
const edm4eic::Measurement2DCollection& meas2Ds) {


// create sourcelink and measurement containers
Expand Down
4 changes: 2 additions & 2 deletions src/algorithms/tracking/CKFTracking.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ namespace eicrecon {
std::vector<ActsExamples::Trajectories*>,
std::vector<ActsExamples::ConstTrackContainer*>
>
process(const edm4eic::Measurement2DCollection& meas2Ds,
const edm4eic::TrackParametersCollection &init_trk_params);
process(const edm4eic::TrackParametersCollection& init_trk_params,
const edm4eic::Measurement2DCollection& meas2Ds);

private:
std::shared_ptr<spdlog::logger> m_log;
Expand Down
4 changes: 2 additions & 2 deletions src/global/tracking/CKFTracking_factory.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ class CKFTracking_factory :
m_acts_trajectories_output(),
m_acts_tracks_output()
) = m_algo->process(
*m_measurements_input(),
*m_parameters_input()
*m_parameters_input(),
*m_measurements_input()
);
}
};
Expand Down

0 comments on commit 5e39885

Please sign in to comment.