HcalEndcapPInsertImagingProtoClusters: use a larger hit spacing threshold #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
Capybara summary for PR 1595 |
use an appropriate distance between subcell hits.
for more information, see https://pre-commit.ci
sebouh137
changed the title
veprbl
reviewed
Aug 26, 2024
veprbl
reviewed
Aug 26, 2024
veprbl
reviewed
Aug 26, 2024
use cell side_length from geometry
veprbl
reviewed
Aug 26, 2024
appease iwyu
Co-authored-by: Dmitry Kalinkin <[email protected]>
runtime_exception --> runtime_error
catch, not except
appease iwyu
|
|
@veprbl, all of the checks now pass, and I have tested to make sure that it runs locally on my laptop. If there is no further change you need from me, please approve this pull requeset. |
veprbl
changed the title
veprbl
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Uses a larger threshold for the distance between the neighboring hits in the insert, due to the new cell size. Also include "side" field (ie, left vs right) in the hit merger algorithm
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Probably. Including the detector "side" as a field in the hit merger algorithm probably breaks the code if using a version of the epic repository from before pull request eic/epic#771 is merged. Therefore this pull request and eic/epic#771 should be merged at the same time as one another
Does this PR change default behavior?
yes. Changes the parameters of the topo clustering and also uses the "side" field in the hit merger.