Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added PrimaryVertices factory (subCollection of CentralTrackVertices) #1609

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

starsdong
Copy link
Contributor

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@wdconinc
Copy link
Contributor

wdconinc commented Sep 9, 2024

@simonge can you make this a meta factory subset collection?

src/algorithms/reco/PrimaryVertices.cc Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVertices.h Outdated Show resolved Hide resolved
src/global/reco/PrimaryVertices_factory.h Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVertices.h Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVertices.cc Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVertices.cc Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVerticesConfig.h Outdated Show resolved Hide resolved
@simonge
Copy link
Contributor

simonge commented Sep 9, 2024

@simonge can you make this a meta factory subset collection?

After a quick look I don't think this is possible at the moment. We would need the BooleanSplit functor from #1587, then getting the magnitude of the components of the position would need to be direct member functions, or extra code of the edm4eic::Vertex rather than getPosition().magnitudeTransverse() (Which looks like itself would need to be extended to accept 4d vectors). That to just filter the vertices.

A new functor would then be needed to sort/reduce the vertices in a secondary factory.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is still derived from Daniel's code, we ought to keep the credits.

src/algorithms/reco/PrimaryVertices.cc Outdated Show resolved Hide resolved
src/algorithms/reco/PrimaryVertices.h Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections raised.

@veprbl veprbl added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit ca9579e Sep 17, 2024
86 of 87 checks passed
@veprbl veprbl deleted the pr/primaryvertices branch September 17, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants