-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added PrimaryVertices factory (subCollection of CentralTrackVertices) #1609
Conversation
@simonge can you make this a meta factory subset collection? |
After a quick look I don't think this is possible at the moment. We would need the BooleanSplit functor from #1587, then getting the magnitude of the components of the position would need to be direct member functions, or extra code of the edm4eic::Vertex rather than getPosition().magnitudeTransverse() (Which looks like itself would need to be extended to accept 4d vectors). That to just filter the vertices. A new functor would then be needed to sort/reduce the vertices in a secondary factory. |
…into pr/primaryvertices
for more information, see https://pre-commit.ci
Capybara summary for PR 1609
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is still derived from Daniel's code, we ought to keep the credits.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections raised.
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?