Building pulses from SimCalorimeterHitProcessor #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: calorimetry
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Capybara summary for PR 1924
|
wdconinc
reviewed
Jun 28, 2025
|
|
||
| public: | ||
| virtual ~SignalPulse() = default; // Virtual destructor | ||
| virtual double operator()(double time, double charge) = 0; |
There was a problem hiding this comment.
This getter must be const. It should have always been const, and the EvaluatorPulse will need to deal with the map of parameters in a different way.
Comment on lines
+84
to
86
| if (type == "LandauPulse") { | ||
| return std::make_unique<LandauPulse>(params); | ||
| } |
There was a problem hiding this comment.
Factory must support all types.
|
|
||
| void CalorimeterPulseGeneration::init() { | ||
| // Initialize seed | ||
| m_gen.seed(std::random_device{}()); |
There was a problem hiding this comment.
This makes the algorithm irreproducible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This algorithm,
CalorimeterPulseGeneration, builds pulses for each hit implemented bySimCalorimeterHitProcessor. Sub-pulses were created for each contribution and combined to build pulse of a hit. Regarding the pulse shape, template pulse implemented bySiliconPulseGenerationwas used. Before the sub-pulses are created, the energy deposit can be converted to number of photoelectrons if necessary.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?