Skip to content

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 1, 2025

Briefly, what does this PR introduce?

This adds a CITATION.cff file to the repository, linking to the zenodo entry, https://zenodo.org/records/15880663. Names autogenerated from zenodo. Unresolved names (i.e. just github username) removed.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch.

- family-names: Daniel Brandenburg
- family-names: Dhevan Gangadharan
cff-version: 1.2.0
date-released: '<replace with the actual release date>'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention behind this was to avoid people just including a reference without any version at all. If we put a real version here, then it would just go out of sync.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume if we omit, Zenodo will fill this in?

Looking at https://github.com/scikit-hep/uproot5/blob/main/CITATION.cff
they put date-released for the original release date and version is not specified.

Each version on Zeonodo is already provided with an unique DOI, we don't need to make a CITATION.cff to address that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that people won't (only) go to zenodo for the citation, but copy it directly from GitHub, see https://github.com/eic/epic/ and the "Cite this repository" menu on the right sidebar. That's based purely on what's inside the cff file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should be removing the cff file from eic/epic and replacing it with a Zenodo link in the README?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we have here... and it isn't working. I think having the "Cite this repository" is a better solution than expecting people to know they can cite zenodo. They (especially now) think of zenodo as a place for internal documents.

repository-code: https://github.com/eic/EICrecon
title: 'eic/EICrecon: <replace with the actual version>'
type: software
version: '<replace with the actual version>'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these?

- family-names: Peter Steinberg
- family-names: Minho Kim
- family-names: Daniel Brandenburg
- family-names: Dhevan Gangadharan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we keep this up to date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about that too. It's related to the problem with the versions. If we could automate our version release workflow and include a download of a new CITATION.cff, then we can get away from this. Otherwise, I am just tempted to keep it as is, and replace it maybe on demand (we can add a comment line to the file) or on schedule. We could probably even do a scheduled job that downloads the file, checks for diffs, and opens a PR with the necessary changes. But that's all work...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, the assumption here, again, that we somehow track this better then Zenodo can. I don't quite understand how a job would source some better information (parse spdx headers?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're overthinking the job. It would consist of curl https://zenodo.org/records/15880663/export/cff with some massaging :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's until Zenodo will start feeding you your own cff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the curl in curl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants