-
Notifications
You must be signed in to change notification settings - Fork 32
Add automated reconstruction quality analysis workflow for truth-reconstruction comparisons #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: wdconinc <[email protected]>
…handling Co-authored-by: wdconinc <[email protected]>
…t file handling Co-authored-by: wdconinc <[email protected]>
for more information, see https://pre-commit.ci
@copilot The new job steps fail with:
Revisit the |
…analysis script Co-authored-by: wdconinc <[email protected]>
... Fixed the awkward array boolean evaluation error in commit 8df9a7b. The issue was on line 278 where |
compare_reconstruction_truth.py
if not data:
with proper type-specific checksFixed Issues
Problem: The GitHub Actions workflow
reconstruction-quality-analysis
was failing with:Root Cause: Line 278 in
scripts/compare_reconstruction_truth.py
was usingif not data:
wheredata
is an awkward array returned fromtree.arrays()
. Awkward arrays cannot be directly evaluated as boolean when they contain multiple elements.Solution: Replaced the problematic boolean evaluation with proper type-specific checks:
isinstance(data, dict) and not data
- handles empty dict from error caseshasattr(data, 'fields') and len(data.fields) == 0
- handles awkward arrays with no fieldsThis maintains the same logical behavior while avoiding the ValueError with awkward arrays.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.