Flag clusters as EMCal or HCal #2078
Open
+210
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: calorimetry
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/17840742667. Please merge this PR into the branch `for-calo-type-flag` to resolve failures in PR #2078. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR introduces two new flags to the
Jug::Reco::ClusterTypeinalgorithms/calorimetry/ClusterTypes,kClusterEMCalandkClusterHCal. These flags are intended to help facilitate generic algorithms downstream which need to distinguish between EM and hadronic energy.These are new types are used to flag only the types of clusters which will be passed on to downstream, holistic algorithms such as the output of
CalorimeterClusterRecoCoG(for all calorimeters other than the BIC) orEnergyPositionClusterMerger(for the BIC).Note: this is intended to be an interim solution, aimed at facilitating development on downstream PF algorithms and maintaining momentum (see the presentation here for more details on the PF development plan). A longer-term, more flexible approach is discussed in EDM4eic#122.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.