Skip to content

Merge main into irt-2.1b #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Merge main into irt-2.1b #2106

wants to merge 21 commits into from
+863 −270

Conversation

chchatte92
Copy link
Member

Briefly, what does this PR introduce?

This PR merges the deviated branches. The base branch irt-2.1b will be up-to-date to main.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __
    Update current branch to main.

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators
    Alexander Kiselev has been added as a Reviewer. Modifications based on the ePIC, EDM4EIC are also followed.

Does this PR introduce breaking changes? What changes might users need to make to their code?

Tests will be made

Does this PR change default behavior?

No

pre-commit-ci bot and others added 6 commits September 25, 2025 20:54
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#2089)
2aed162 
<!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/mirrors-clang-format: v21.1.0 →
v21.1.1](pre-commit/mirrors-clang-format@v21.1.0...v21.1.1)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ssedd1123 @pre-commit-ci
@veprbl @simonge @wdconinc @github-actions
Add LGADHitReconstruction that does clustering (#1779)
4c47edc 
### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

TOFBarrelRecHits is now generated from the new class
"LGADHitReconstruction". This class takes the digitized ADC and TDC
values from each strips within the BTOF sensor to reconstruct the hit
location, hit time and energy deposition.

Currently, this class is just a skeleton with position calculated by a
simple weighted average, energy is just the sum of ADC values inside a
sensor and time is just the earliest TDC value within a sensor,
transformed linearly to get a rough time and EDep. There is no time walk
correction and this class is unable to distinguish multiple hits in the
same sensor if they arrive within the same EICROC cycle (25 ns).
However, our group is developing a more sophisticated clustering
algorithm and the time walk correction will be implemented in the future
in another pull request. This is just a skeletal class for our group to
develop further.

Name of the class is still open for discussion. See #1778

### Does this PR change default behavior?

TOFBarrelRecHits is now generated by LGADHitReconstruction. If
TOFBarrelRecHits are used by downstream classes for track
reconstruction, I believe it will lower the tracking efficiency because
digitization class discard hits with too low energy threshold. The lack
of time walk correction and energy loss through the boundaries of BTOF
sensor also contributes to the worsening of position resolution, which
may or may not have huge ramifications.

Part of the reason I make this pull request is precisely because I don't
fully understand it's downstream effect. Please feel free to let me know
if any part of the performance is significantly degraded.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Simon Gardner <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#2093)
b47da43 
<!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/mirrors-clang-format: v21.1.1 →
v21.1.2](pre-commit/mirrors-clang-format@v21.1.1...v21.1.2)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wdconinc @pre-commit-ci
fix: adapt to acts#4640 which introduces ActsPlugins as namespace (#2095
c7d1823 
)

### Briefly, what does this PR introduce?
This PR adapts to acts-project/acts#4640 by
including the right header and using the right namespace.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @veprbl 

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ruse-traveler
Make WithPodConfig public in ScatteredElectronsEMinusPz (#2099)
27760c7 
### Briefly, what does this PR introduce?

This PR exposes the public `WithPodConfig` members in
`ScatteredElectronsEMinusPz`.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #2098 )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

No.

### Does this PR change default behavior?

No.
@chchatte92
Adjustment of dRICH aerogel index to 1.026 (#2102)
8ef045a 
### Briefly, what does this PR introduce?
The refractive index for the dRICH aerogel has been adjusted.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ X] Other: __
The average index of the dRICH aerogel refractive index has been set to
1.026.

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ X] Changes have been communicated to collaborators
@kumardeepraman is aware.
### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

Co-authored-by: chchatte92 <[email protected]>
@github-actions github-actions bot added topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: infrastructure topic: barrel topic: digitization labels Oct 7, 2025
@chchatte92
Copy link
Member Author

@alexander-kiselev this draft PR is merging the deflected main into irt-2.1b

@chchatte92 chchatte92 self-assigned this Oct 7, 2025
@chchatte92 chchatte92 mentioned this pull request Oct 7, 2025
Closed
6 tasks
dependabot bot added 2 commits October 7, 2025 15:00
@dependabot
build(deps): bump peter-evans/find-comment from 3 to 4 (#2104)
8a34d1c 
Bumps
[peter-evans/find-comment](https://github.com/peter-evans/find-comment)
from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/peter-evans/find-comment/releases">peter-evans/find-comment's
releases</a>.</em></p>
<blockquote>
<h2>Find Comment v4.0.0</h2>
<p>⚙️ Requires <a
href="https://github.com/actions/runner/releases/tag/v2.327.1">Actions
Runner v2.327.1</a> or later if you are using a self-hosted runner for
Node 24 support.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.28 to
18.19.30 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/301">peter-evans/find-comment#301</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.30 to
18.19.31 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/302">peter-evans/find-comment#302</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.31 to
18.19.33 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/303">peter-evans/find-comment#303</a></li>
<li>build(deps-dev): bump prettier from 3.2.5 to 3.3.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/304">peter-evans/find-comment#304</a></li>
<li>build(deps-dev): bump prettier from 3.3.0 to 3.3.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/305">peter-evans/find-comment#305</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.33 to
18.19.34 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/306">peter-evans/find-comment#306</a></li>
<li>build(deps-dev): bump prettier from 3.3.1 to 3.3.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/307">peter-evans/find-comment#307</a></li>
<li>build(deps-dev): bump braces from 3.0.2 to 3.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/308">peter-evans/find-comment#308</a></li>
<li>build(deps-dev): bump ws from 7.5.9 to 7.5.10 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/309">peter-evans/find-comment#309</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.34 to
18.19.39 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/310">peter-evans/find-comment#310</a></li>
<li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/311">peter-evans/find-comment#311</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/312">peter-evans/find-comment#312</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.39 to
18.19.41 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/313">peter-evans/find-comment#313</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.41 to
18.19.42 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/314">peter-evans/find-comment#314</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.42 to
18.19.43 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/315">peter-evans/find-comment#315</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.43 to
18.19.44 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/316">peter-evans/find-comment#316</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.44 to
18.19.45 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/317">peter-evans/find-comment#317</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.45 to
18.19.47 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/318">peter-evans/find-comment#318</a></li>
<li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/319">peter-evans/find-comment#319</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.47 to
18.19.50 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/320">peter-evans/find-comment#320</a></li>
<li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/321">peter-evans/find-comment#321</a></li>
<li>build(deps-dev): bump <code>@​vercel/ncc</code> from 0.38.1 to
0.38.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/322">peter-evans/find-comment#322</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.50 to
18.19.54 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/323">peter-evans/find-comment#323</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/find-comment/pull/324">peter-evans/find-comment#324</a></li>
<li>build(deps): bump <code>@​actions/core</code> from 1.10.1 to 1.11.1
by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/325">peter-evans/find-comment#325</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/find-comment/pull/326">peter-evans/find-comment#326</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.54 to
18.19.55 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/327">peter-evans/find-comment#327</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.55 to
18.19.57 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/328">peter-evans/find-comment#328</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.57 to
18.19.59 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/329">peter-evans/find-comment#329</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.59 to
18.19.63 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/330">peter-evans/find-comment#330</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.63 to
18.19.64 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/331">peter-evans/find-comment#331</a></li>
<li>build(deps-dev): bump <code>@​vercel/ncc</code> from 0.38.2 to
0.38.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/332">peter-evans/find-comment#332</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.64 to
18.19.65 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/333">peter-evans/find-comment#333</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.65 to
18.19.67 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/334">peter-evans/find-comment#334</a></li>
<li>build(deps-dev): bump prettier from 3.3.3 to 3.4.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/335">peter-evans/find-comment#335</a></li>
<li>build(deps-dev): bump prettier from 3.4.1 to 3.4.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/336">peter-evans/find-comment#336</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.67 to
18.19.68 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/337">peter-evans/find-comment#337</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.68 to
18.19.69 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/338">peter-evans/find-comment#338</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.69 to
18.19.70 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/339">peter-evans/find-comment#339</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.2.1 to 5.2.3 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/340">peter-evans/find-comment#340</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.70 to
18.19.71 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/341">peter-evans/find-comment#341</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.71 to
18.19.74 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/342">peter-evans/find-comment#342</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.74 to
18.19.75 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/343">peter-evans/find-comment#343</a></li>
<li>build(deps-dev): bump prettier from 3.4.2 to 3.5.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/344">peter-evans/find-comment#344</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.75 to
18.19.76 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/345">peter-evans/find-comment#345</a></li>
<li>build(deps): bump <code>@​octokit/request-error</code> and
<code>@​actions/github</code> by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/find-comment/pull/346">peter-evans/find-comment#346</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/peter-evans/find-comment/commit/b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad"><code>b30e6a3</code></a>
feat: v4 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/389">#389</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/b4929e71ca41482784c4f845c7067ac87b37ea13"><code>b4929e7</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.124 to
18.19.127 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/388">#388</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/1f47d948b68bb443374bdb9b471ba07c8f56cc55"><code>1f47d94</code></a>
build(deps-dev): bump <code>@​vercel/ncc</code> from 0.38.3 to 0.38.4
(<a
href="https://redirect.github.com/peter-evans/find-comment/issues/387">#387</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/a723a15ad60cf9419c01a6b8c9548ddd15e79531"><code>a723a15</code></a>
build(deps): bump actions/setup-node from 4 to 5 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/386">#386</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/8bacb1b93208eb5905c5587b30951a392eb18df0"><code>8bacb1b</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.123 to
18.19.124 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/385">#385</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/048de657d50358ed23c7ac2297a319ada251f4f0"><code>048de65</code></a>
build(deps): bump actions/checkout from 4 to 5 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/384">#384</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/c02750f02d104fe45b3d5d5a951ddf251878c770"><code>c02750f</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.122 to
18.19.123 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/383">#383</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/092c582425a50e7fcdc2734bc8879d28bcc4ae27"><code>092c582</code></a>
build(deps): bump actions/download-artifact from 4 to 5 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/382">#382</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/c115bb0099cf72f71ae983aab8b653ab541bccc4"><code>c115bb0</code></a>
build(deps-dev): bump eslint-plugin-prettier from 5.5.3 to 5.5.4 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/381">#381</a>)</li>
<li><a
href="https://github.com/peter-evans/find-comment/commit/8d3be5d71090a36b64b16ec89b798e1c7373333d"><code>8d3be5d</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.121 to
18.19.122 (<a
href="https://redirect.github.com/peter-evans/find-comment/issues/380">#380</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/peter-evans/find-comment/compare/v3...v4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/find-comment&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump peter-evans/create-or-update-comment from 4 to 5 (#…
1da2e12 
…2105)

Bumps
[peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment)
from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/peter-evans/create-or-update-comment/releases">peter-evans/create-or-update-comment's
releases</a>.</em></p>
<blockquote>
<h2>Create or Update Comment v5.0.0</h2>
<p>⚙️ Requires <a
href="https://github.com/actions/runner/releases/tag/v2.327.1">Actions
Runner v2.327.1</a> or later if you are using a self-hosted runner for
Node 24 support.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump peter-evans/create-or-update-comment from 3 to 4
by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/307">peter-evans/create-or-update-comment#307</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.8 to
18.19.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/308">peter-evans/create-or-update-comment#308</a></li>
<li>build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/310">peter-evans/create-or-update-comment#310</a></li>
<li>build(deps): bump peter-evans/create-pull-request from 5 to 6 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/309">peter-evans/create-or-update-comment#309</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.11 to
18.19.14 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/311">peter-evans/create-or-update-comment#311</a></li>
<li>build(deps-dev): bump prettier from 3.2.4 to 3.2.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/312">peter-evans/create-or-update-comment#312</a></li>
<li>build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.8.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/313">peter-evans/create-or-update-comment#313</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.14 to
18.19.15 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/314">peter-evans/create-or-update-comment#314</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.15 to
18.19.17 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/315">peter-evans/create-or-update-comment#315</a></li>
<li>build(deps-dev): bump eslint-plugin-jest from 27.8.0 to 27.9.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/316">peter-evans/create-or-update-comment#316</a></li>
<li>build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/318">peter-evans/create-or-update-comment#318</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.17 to
18.19.19 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/319">peter-evans/create-or-update-comment#319</a></li>
<li>build(deps-dev): bump eslint-plugin-github from 4.10.1 to 4.10.2 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/320">peter-evans/create-or-update-comment#320</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.19 to
18.19.21 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/321">peter-evans/create-or-update-comment#321</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.21 to
18.19.23 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/322">peter-evans/create-or-update-comment#322</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.23 to
18.19.26 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/325">peter-evans/create-or-update-comment#325</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.26 to
18.19.29 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/326">peter-evans/create-or-update-comment#326</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.29 to
18.19.31 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/327">peter-evans/create-or-update-comment#327</a></li>
<li>build(deps): bump chuhlomin/render-template from 1.9 to 1.10 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/328">peter-evans/create-or-update-comment#328</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.31 to
18.19.32 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/329">peter-evans/create-or-update-comment#329</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.32 to
18.19.33 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/330">peter-evans/create-or-update-comment#330</a></li>
<li>build(deps-dev): bump prettier from 3.2.5 to 3.3.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/332">peter-evans/create-or-update-comment#332</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.33 to
18.19.34 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/333">peter-evans/create-or-update-comment#333</a></li>
<li>build(deps-dev): bump prettier from 3.3.0 to 3.3.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/334">peter-evans/create-or-update-comment#334</a></li>
<li>build(deps-dev): bump braces from 3.0.2 to 3.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/335">peter-evans/create-or-update-comment#335</a></li>
<li>build(deps-dev): bump ws from 7.5.9 to 7.5.10 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/336">peter-evans/create-or-update-comment#336</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.34 to
18.19.36 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/337">peter-evans/create-or-update-comment#337</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.36 to
18.19.39 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/338">peter-evans/create-or-update-comment#338</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.39 to
18.19.40 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/340">peter-evans/create-or-update-comment#340</a></li>
<li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/339">peter-evans/create-or-update-comment#339</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.40 to
18.19.42 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/342">peter-evans/create-or-update-comment#342</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/343">peter-evans/create-or-update-comment#343</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.42 to
18.19.43 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/345">peter-evans/create-or-update-comment#345</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.43 to
18.19.44 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/347">peter-evans/create-or-update-comment#347</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.44 to
18.19.45 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/348">peter-evans/create-or-update-comment#348</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.45 to
18.19.47 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/349">peter-evans/create-or-update-comment#349</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.47 to
18.19.49 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/350">peter-evans/create-or-update-comment#350</a></li>
<li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/351">peter-evans/create-or-update-comment#351</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.49 to
18.19.50 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/352">peter-evans/create-or-update-comment#352</a></li>
<li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/353">peter-evans/create-or-update-comment#353</a></li>
<li>build(deps-dev): bump <code>@​vercel/ncc</code> from 0.38.1 to
0.38.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/354">peter-evans/create-or-update-comment#354</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.50 to
18.19.51 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/355">peter-evans/create-or-update-comment#355</a></li>
<li>Update distribution by <a
href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/356">peter-evans/create-or-update-comment#356</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.51 to
18.19.54 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/357">peter-evans/create-or-update-comment#357</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.54 to
18.19.55 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/359">peter-evans/create-or-update-comment#359</a></li>
<li>build(deps): bump <code>@​actions/core</code> from 1.10.1 to 1.11.1
by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/360">peter-evans/create-or-update-comment#360</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/e8674b075228eee787fea43ef493e45ece1004c9"><code>e8674b0</code></a>
feat: v5 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/439">#439</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/fffe59ea229327e73edca9d31f0b578bf04152a9"><code>fffe59e</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.127 to
18.19.129 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/438">#438</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/076d57233ac816370d98e4a8471745e4bab20c6e"><code>076d572</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.126 to
18.19.127 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/437">#437</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/86a26452a5212846cda64bb7e75c7129eb695ec9"><code>86a2645</code></a>
build(deps-dev): bump <code>@​vercel/ncc</code> from 0.38.3 to 0.38.4
(<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/436">#436</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/be17e0c03de886b7aff3fb3224d28bfb6fc5d114"><code>be17e0c</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.124 to
18.19.126 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/435">#435</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/ef75eae2348215adbd501f243281835beaa69d3f"><code>ef75eae</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.123 to
18.19.124 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/433">#433</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/82a7ad083d3b3a0a18b53e0e5f3bbe9dd3841260"><code>82a7ad0</code></a>
build(deps): bump actions/setup-node from 4 to 5 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/432">#432</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/f7c845d742ddcc26436b9547b75f949bdcd3012a"><code>f7c845d</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.122 to
18.19.123 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/430">#430</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/5da8e07780620d4c63e2e4144177b7d2020b5996"><code>5da8e07</code></a>
build(deps-dev): bump eslint-plugin-prettier from 5.5.3 to 5.5.4 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/428">#428</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/2de7f661fe1d25b1982bdc7eee29ca30f8f97fd2"><code>2de7f66</code></a>
build(deps-dev): bump <code>@​types/node</code> from 18.19.121 to
18.19.122 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/427">#427</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-or-update-comment&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ruse-traveler @pre-commit-ci @simonge
Add missing config declaration/application to `ScatteredElectronsEMin…
c061e22 
…usPz_factory` (#2101)

### Briefly, what does this PR introduce?

This PR adds the parameter ref's and config application to the
`ScatteredElectronsEMinusPz` factory.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #2100 )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

No.

### Does this PR change default behavior?

No.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Simon Gardner <[email protected]>
@kumardeepraman @pre-commit-ci
Updated pid_lut.cc (#2103)
90fbb0a 
### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [.] Changes have been communicated to collaborators
@chchatte92 is aware of this development. 


### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
wdconinc and others added 2 commits October 9, 2025 02:34
@wdconinc
clang-tidy: modernize-use-designated-initializers (#2109)
f902817 
### Briefly, what does this PR introduce?
This PR applies clang-tidy modernize-use-designated-initializers check
fixes from main.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: code base should satisfy PR clang-tidy
requirements)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
@wdconinc @pre-commit-ci
EcalBarrelScFiProtoClusters: use localDistXY instead of localDistXZ (#…
192ae12 
…2094)

### Briefly, what does this PR introduce?
The island clustering in the BEMC EcalBarrelScFiProtoClusters should
happen in the XY plane, not the XZ plane. This should remove the
unreasonable effectiveness of the island clustering for two gammas in
the same sector. We only gain Z information when we add timing analysis,
and we don't lose the Y information at that point but combine it all in
topological clustering.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: EcalBarrelScFiProtoClusters unreasonably
effective)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Yes, makes EcalBarrelScFiProtoClusters worse.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wdconinc
clang-tidy: modernize-use-emplace (#2114)
bc37be1 
### Briefly, what does this PR introduce?
This PR applies clang-tidy modernize-use-emplace check fixes from main.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: code base should satisfy PR clang-tidy
requirements)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
@alexander-kiselev
Copy link

None

veprbl and others added 2 commits October 13, 2025 16:55
@veprbl
treewide: remove Acts 33 support (#2122)
b0ce7ff 
### Briefly, what does this PR introduce?
We are dropping support for old containers
#1954, so the ifdef's are not
needed anymore.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
No

Co-authored-by: Dmitry Kalinkin <[email protected]>
@wdconinc @github-actions
clang-tidy: readability-container-size-empty (#2116)
60aef98 
### Briefly, what does this PR introduce?
This PR applies clang-tidy readability-container-size-empty check fixes
from main.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: code base should satisfy PR clang-tidy
requirements)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mhkim-anl and others added 2 commits October 14, 2025 02:30
@mhkim-anl @veprbl
[BIC] Use the new reference positions for attenuation (#2120)
2868c0b 
### Briefly, what does this PR introduce?
This PR is to use the new reference positions,
`EcalBarrel_LightGuide_{Positive, Negative}PosZ`, implemented in
[ePIC_PR#956](eic/epic#956) for attenuation.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #2097)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

Co-authored-by: Dmitry Kalinkin <[email protected]>
@veprbl @pre-commit-ci
Updated sensor and light yield constants for EEEMCal digitization (#2131
fb6eb58 
)

### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
Yes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wdconinc @github-actions
clang-tidy: modernize-use-std-numbers (#2112)
717b2d1 
### Briefly, what does this PR introduce?
This PR applies clang-tidy modernize-use-std-numbers check fixes from
main.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: code base should satisfy PR clang-tidy
requirements)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chchatte92
Copy link
Member Author

@wdconinc; as per our discussion last Monday I am closing this PR as well.

@chchatte92 chchatte92 closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-kiselev alexander-kiselev Awaiting requested review from alexander-kiselev

Assignees

@chchatte92 chchatte92

Labels

topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: digitization topic: far-backward Reconstruction related to far backward detectors topic: forward topic: infrastructure topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@chchatte92 @alexander-kiselev @veprbl @kumardeepraman @ssedd1123 @wdconinc @ruse-traveler @freee458 @mhkim-anl