Skip to content

[BIC] Use the new reference positions for attenuation #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

[BIC] Use the new reference positions for attenuation #2120

merged 3 commits into from
Oct 14, 2025

Conversation

mhkim-anl
Copy link
Contributor

Briefly, what does this PR introduce?

This PR is to use the new reference positions, EcalBarrel_LightGuide_{Positive, Negative}PosZ, implemented in ePIC_PR#956 for attenuation.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@mhkim-anl mhkim-anl linked an issue Oct 8, 2025 that may be closed by this pull request
[BIC] Use the new reference positions for attenuation #2097
Closed
@mhkim-anl mhkim-anl self-assigned this Oct 8, 2025
@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: barrel labels Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Capybara summary for PR 2120

veprbl
veprbl approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 2868c0b Oct 14, 2025
130 of 132 checks passed
@veprbl veprbl deleted the 2097-new-reference-positions-for-attenuation branch October 14, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@wdconinc wdconinc Awaiting requested review from wdconinc

@sly2j sly2j Awaiting requested review from sly2j

@mariakzurek mariakzurek Awaiting requested review from mariakzurek

Assignees

@mhkim-anl mhkim-anl

Labels

topic: barrel topic: calorimetry relates to calorimetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BIC] Use the new reference positions for attenuation

2 participants

@mhkim-anl @veprbl