Implement Charged Candidate Maker (PFA1b) #2124
Conversation
for more information, see https://pre-commit.ci
…c/EICrecon into add-track-cluster-subtraction-pfa-one
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…c/EICrecon into add-track-cluster-subtraction-pfa-one
for more information, see https://pre-commit.ci
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/17247257038. Please merge this PR into the branch `add-track-cluster-subtraction-pfa-one` to resolve failures in PR #1627. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-candidate-maker-pfa-one
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/18477471601. Please merge this PR into the branch `add-track-cluster-subtraction-pfa-one` to resolve failures in PR #1627. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/18477497612. Please merge this PR into the branch `add-charged-candidate-maker-pfa-one` to resolve failures in PR #2124. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
Not sure about the particle/ namespace instead of reco/, but we can have it.
Thanks! My thinking here is that PFAlpha is the starting point for broader PF efforts, so, over time, this namespace will be filled with more algorithms. One thing to consider might be to move some of our existing PF algorithms into this namespace: that way all of our particle reconstruction algorithms are in one place. This would be a step towards factoring the existing |
ruse-traveler
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@ruse-traveler I'm noticing this is targeting add-charged-candidate-maker-pfa-one branch instead of main. Is that intentional? |
Ah! That was intentional: I wasn't sure what order we would want to review these in, so I pointed it at the PFA1(a) branch in the interim. It's extremely straight-forward to swap it around and point it at main, though! |
|
So we need to unblock the #1699 first? Should we make the EDM4eic model change that we've discussed before? |
|
I don't think we need to unblock PFA0 for this one since I can always use the output of the track-cluster matcher as input for this algorithm until we're ready to tie things together! But we probably should make that data-model change soon to let work resume on PFA0... I can open a PR later this week! |
ruse-traveler
changed the base branch from
add-track-cluster-subtraction-pfa-one
to
main
Briefly, what does this PR introduce?
This PR implements the
ChargedCandidateMakeralgorithm. This algorithm ingests track-cluster matches and converts them to charged particle candidates, i.e.edm4eic::ReconstructedParticleswith only select relations filled.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.