Implement Charged Candidate Maker (PFA1b) #2124
Open
+266
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 9, 2025
veprbl
reviewed
Oct 10, 2025
for more information, see https://pre-commit.ci
…-candidate-maker-pfa-one
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/18477497612. Please merge this PR into the branch `add-charged-candidate-maker-pfa-one` to resolve failures in PR #2124. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
veprbl
reviewed
Oct 14, 2025
There was a problem hiding this comment.
Duplicate file? All factories go to factories/
|
|
||
| app->Add(new JOmniFactoryGeneratorT<ChargedCandidateMaker_factory>( | ||
| "EndcapPInsertChargedCandidateParticlesAlpha", {"EndcapPInsertTrackExpectedClusterMatches"}, | ||
| {"EndcapPInsertChargedCandidateParticlesAlpha"}, {}, app)); |
There was a problem hiding this comment.
We might want to (temporarily?), add these to the list in JPODIOEventProcessor.cc, we want to have these factories running. Alternative is to add a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR implements the
ChargedCandidateMakeralgorithm. This algorithm ingests track-cluster matches and converts them to charged particle candidates, i.e.edm4eic::ReconstructedParticleswith only select relations filled.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.