ACTSGeo_service.cc: rename geom const materials-map -> material-map #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
wdconinc
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
This inconsistency came from ATHENA days. I think we originally had material-maps.json, then @sly2j said that's the wrong name and we ended up with materials-map.cbor, and we just kinda gave up on it then. Thanks for fixing it!
wdconinc
force-pushed
the
pr/material-map_const_rename
branch
from
fcf6d60
to
fe5973a
Compare
The eic/epic#494 is not merged at this time. Let's update that one to provide both constants, but going forward use proper meaning one.
wdconinc
force-pushed
the
pr/material-map_const_rename
branch
from
fe5973a
to
1b0c682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eic/epic#494 is not merged at this time. Let's update that one to provide both constants, but going forward use proper meaning one.