Releases: eic/EICrecon
Releases · eic/EICrecon
v1.30.0
What's Changed
🕸️ Tracking
- Add LGADHitReconstruction that does clustering by @ssedd1123 in #1779
- fix: adapt to acts#4640 which introduces ActsPlugins as namespace by @wdconinc in #2095
- clang-tidy: modernize-use-designated-initializers by @wdconinc in #2109
- treewide: remove Acts 33 support by @veprbl in #2122
- clang-tidy: readability-container-size-empty by @wdconinc in #2116
🪪 Particle identification
- Adjustment of dRICH aerogel index to 1.026 by @chchatte92 in #2102
- Adding digitization in Forward Time of Flight detector by @freee458 in #2053
🚿 Calorimetry
- fix: Add debug logs for time cap exceedance in hits; don't skip them by @wdconinc in #2081
- EcalBarrelScFiProtoClusters: use localDistXY instead of localDistXZ by @wdconinc in #2094
- clang-tidy: readability-use-std-min-max by @wdconinc in #2110
- treewide: remove EDM4eic 7.x support by @veprbl in #2121
- clang-tidy: modernize-use-emplace by @wdconinc in #2114
- [BIC] Use the new reference positions for attenuation by @mhkim-anl in #2120
- Updated sensor and light yield constants for EEEMCal digitization by @veprbl in #2131
⏪ Far Backward
⚙️ Infrastructure
- Update release.yml: add dependabot to changelog.exclude.authors by @veprbl in #2079
- Temporarily disable omnifactory tests due to changing JANA2 internals by @nathanwbrei in #1998
🔩 Other Changes
- attempt to remove the pid_lut theta overflow bins by @simonge in #2083
- Make WithPodConfig public in
ScatteredElectronsEMinusPz
by @ruse-traveler in #2099 - Add missing config declaration/application to
ScatteredElectronsEMinusPz_factory
by @ruse-traveler in #2101 - Updated pid_lut.cc by @kumardeepraman in #2103
New Contributors
- @kumardeepraman made their first contribution in #2103
- @freee458 made their first contribution in #2053
Full Changelog: v1.29.0...v1.30.0
v1.29.1
What's Changed
🚿 Calorimetry
- [Backport v1.29] fix: Add debug logs for time cap exceedance in hits; don't skip them by @epic-capybara in #2085
Full Changelog: v1.29.0...v1.29.1
v1.29.0
What's Changed
🕸️ Tracking
- Reduce verbosity of CKFTracking algorithm by @simonge in #2017
- Fix use-after-move bug in IterativeVertexFinder::extractParameters by @Copilot in #2035
- refactor: Move ParticleSvc to services library and separate interface from implementation by @Copilot in #2032
- fix: remove duplication of edm4eic_indexed_units in
src/algorithms/tracking
by @wdconinc in #2062 - fix: AmbiguitySolver: avoid deprecated call on ACTS main by @wdconinc in #2067
🪪 Particle identification
- fix: remove use of
operator->
for podio collection objects by @wdconinc in #2060 - Pulse generation from time-clustered Simcalorimeterhits using a shared template by @mhkim-anl in #2004
🚿 Calorimetry
- Drop shape calculation from ImagingClusterReco algorithm, use CalorimeterClusterShape instead by @Copilot in #2036
- fix: Add ImagingTopoCluster layer mode within same layers by @AkshayaVijay in #1999
⏪ Far Backward
- Add association for TaggerTrackerReconstructedParticles, use new network with additional inputs by @simonge in #1978
- Use ParticleSvc in FarDetectorTransportationPostML by @simonge in #2016
⏩ Far Forward
⚙️ Infrastructure
- build(deps): bump actions/checkout from 4 to 5 by @dependabot[bot] in #2009
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci[bot] in #2008
- build(deps): bump actions/download-artifact from 4 to 5 by @dependabot[bot] in #2010
- fix: just require ONNX Runtime everywhere by @wdconinc in #2011
- fix: .gitignore calibrations, fieldmaps, gdml by @wdconinc in #2012
- feat(ci): create a pull request for iwyu suggestions by @wdconinc in #1948
- linux-eic-shell.yml: compare MT to previous MT by @veprbl in #2014
- fix: Improve failure message for iwyu pull request by @wdconinc in #2043
- hotfix: workaround color control characters in jug_info by @wdconinc in #2055
- fix: don't create IWYU PRs for dependabot (no permissions) by @wdconinc in #2052
- build(deps): bump actions/upload-pages-artifact from 3 to 4 by @dependabot[bot] in #2050
- fix: rename known-leaking suppressed object
edm4hep::create*Buffers
by @wdconinc in #2057 - [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci[bot] in #2061
- ci: don't fail pragma once check when no headers changed by @wdconinc in #2066
- fix(ci): ensure missing pragma once check handles file deletes gracefully by @wdconinc in #2069
🔩 Other Changes
- fix: explicitly convert signed run number to unsigned for bitset (ubsan fix) by @wdconinc in #2013
- Add NOLINT block to pid_lut by @simonge in #2021
- fix: Update the devcontainer image to eic_ci:nightly by @wdconinc in #2044
- fix: enable strongly-typed enum SiliconChargeSharingConfig::ESigmaMode by @wdconinc in #2015
- fix: remove use of JANA/CLI/JVersion.h by @wdconinc in #2059
New Contributors
- @Copilot made their first contribution in #2036
Full Changelog: v1.28.0...v1.29.0
v1.28.0
What's Changed
🕸️ Tracking
- fix: rm Acts<32 code branch by @wdconinc in #1969
- feat: switch TrackSeeding algorithm/factory to algorithms interface by @wdconinc in #1968
- feat: switch TrackParamTruthInit algorithm/factory to algorithms interface by @wdconinc in #1967
- feat: switch TrackerHitReconstruction algorithm/factories to algorithms interface by @wdconinc in #1966
- feat: switch TrackerMeasurementFromHits to algorithms interface by @wdconinc in #1963
- fix: avoid unused variable warnings with Acts 39 by @wdconinc in #1982
- fix: format according to clang-format-18 by @wdconinc in #1980
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci[bot] in #1801
- feat: ingest EventHeader into digi, generate UID to reseed RNG by @wdconinc in #1934
- fix: use Navigator with MaterialInteractor action for track propagation by @wdconinc in #1977
- fix: re-enable iwyu v0.23 mappings for gcc stl headers by @wdconinc in #1991
- cmake: add acts 43 namespace target prefixes by @veprbl in #1993
- "MPGD.cc": Extend commit #151496af (ingest EventHeader into digi) to the... by @ybedfer in #1996
- feat: inherit jana::components::JOmniFactory and transition to using upstream JOmniFactory by @wdconinc in #1959
- Revert "feat: inherit jana::components::JOmniFactory and transition to using upstream JOmniFactory (#1959)" by @wdconinc in #2005
🪪 Particle identification
- Speed up calculation by reducing BTOF charge sharing magnitude by @ssedd1123 in #1973
- Added new mode to support charge sharing sigma in the units of cell dimension by @ssedd1123 in #1989
- Modified SiliconChargeSharing so it won't miss any hits by @ssedd1123 in #1945
- Switched to using constant fraction discriminator for BTOF sensors by @ssedd1123 in #1974
🚿 Calorimetry
⚙️ Infrastructure
- linux-eic-shell: update llvm-cov from 15 to 18 by @veprbl in #1983
- fix: update llvm-cov from 18 to 19 by @wdconinc in #1985
- .clang-tidy: -readability-math-missing-parentheses by @veprbl in #1990
- remove mentions of JEventProcessorSequentialRoot, deprecate external plugins by @veprbl in #1995
🔩 Other Changes
- feat: allow specifying regex for
podio:output_collections
by @wdconinc in #1939 - feat: switch remaining reco algorithms/factories to algorithms interface by @wdconinc in #1965
- Add phasespace based forced pid for Far-Backward particles. by @simonge in #1894
- Update track reconstruction documentation by @bschmookler in #1987
- fix: clear output vectors of Acts objects before process by @wdconinc in #2003
Full Changelog: v1.27.1...v1.28.0
v1.27.1
What's Changed
⏩ Far Forward
- [Backport v1.27] updated the matrices for the OMD 130 GeV/n deuteron beams by @epic-capybara in #1971
Full Changelog: v1.27.0...v1.27.1
v1.27.0
What's Changed
🕸️ Tracking
- fix: don't use RGB component 280 > 255 by @wdconinc in #1920
- ActsToTracks: don't treat outliers as measurements by @veprbl in #1922
- CalorimeterHitDigi: add photon counter based readout by @veprbl in #1064
- feat: split B0 from central detector tracking by @wdconinc in #1744
- treewide: drop support for EDM4eic older than 7 by @veprbl in #1953
🪪 Particle identification
- feat(ci): run CI pipelines in multi-threaded mode by @wdconinc in #975
- Move dd4hep constant parsing from ZDC, BEMC and FHCAL plugins to algorithm init by @simonge in #1892
- fix: lock to avoid potential data race in IrtCherenkovParticleID by @wdconinc in #1941
🚿 Calorimetry
- Remove EcalEndcapPInsert by @akioogawa in #1852
- fix: avoid duplicate definition of hash in SimHitProcessor by @wdconinc in #1927
- SimCalorimeter Hit Contribution Time After SimCalorimeterHitProcessor Should Include Travel Time #1907 by @mhkim-anl in #1923
⚙️ Infrastructure
- fix(ci): cancel eicweb pipeline if workflow canceled or failed by @wdconinc in #1901
- build(deps): bump dawidd6/action-download-artifact from 10 to 11 by @dependabot in #1917
- Resolve missing symbols when loading plugins by @veprbl in #1910
- remove tof_efficiency benchmarks by @veprbl in #1930
- build(deps): bump platisd/clang-tidy-pr-comments from 1.7.0 to 1.8.0 by @dependabot in #1931
- fix: add a by @wdconinc in #1935
- linux-eic-shell.yml: avoid building container for main branch by @veprbl in #1938
- fix: suppress spurious
lgamma
data race warning by @wdconinc in #1940 - linux-eic-shell.yml: update tested releases (now support containers down to 25.01.1-stable) by @veprbl in #1955
🔩 Other Changes
- Fix deprecation warnings about JEventProcessor constructor by @nathanwbrei in #1911
- Speed improvement in SiliconPulseDiscretization by @ssedd1123 in #1933
- Fix: Energy consistency with momentum and mass/PDG by @bschmookler in #1928
- fix: no-var-tracking during kParticleMap init in ParticleSvc.h by @wdconinc in #1949
- fix: avoid duplicate factory name (CentralTrackVertices) by @wdconinc in #1942
- Run track-cluster matching separately for each calorimeter by @tlprotzman in #1906
- fix: convert MC2SmearedParticle to algorithms, rename by @wdconinc in #1958
New Contributors
- @akioogawa made their first contribution in #1852
Full Changelog: v1.26.0...v1.27.0
v1.26.1
What's Changed
🕸️ Tracking
- [Backport v1.26] ActsToTracks: don't treat outliers as measurements by @epic-capybara in #1926
⚙️ Infrastructure
- [Backport v1.26] Resolve missing symbols when loading plugins by @epic-capybara in #1925
Full Changelog: v1.26.0...v1.26.1
v1.26.0
What's Changed
🕸️ Tracking
- Make tracker measurement from hits more optimal by @simonge in #1870
- fix: Propagate tracks from outermost surface by @bschmookler in #1869
- fix: abs -> std::abs by @wdconinc in #1876
- fix: properly ignore neutrals in TrackParamTruthInit.cc by @wdconinc in #1878
- fix: JApplication.h -> JApplicationFwd.h by @wdconinc in #1880
- Support compilation against Acts 40 and 41 by @veprbl in #1871
- fix: clang-tidy suggestions by @wdconinc in #1875
- Move PID look up tables into global pid_lut file by @simonge in #1745
🪪 Particle identification
- Low-Q2 Charge Sharing by @simonge in #1763
- Move remaining factories out of global by @simonge in #1884
- Move pid_lut plugin detector constants into algorithm by @simonge in #1896
🚿 Calorimetry
- fix(ci): compile with -Wundef by @wdconinc in #1863
- 1776 implementation of the bic attenuated hits by @mhkim-anl in #1783
- Relate merged hit to raw hit of reference by @ruse-traveler in #1883
- fix: move implementation out of headers for compilation speed by @wdconinc in #1853
- fix: don't persist without ID decoder in CalorimeterHitsMerger.cc by @wdconinc in #1900
⏩ Far Forward
⚙️ Infrastructure
- fix: collect min versions in CMakeLists.txt by @wdconinc in #1128
- fix: suppress upstream memory leak by @wdconinc in #1866
- build(deps): bump platisd/clang-tidy-pr-comments from 1.6.1 to 1.7.0 by @dependabot in #1872
- fix(ci): rm unused g++ Debug build by @wdconinc in #1877
- fix: move static ParticleMap into header as inline for downstream use by @wdconinc in #1538
- fix(ci): save clang-tidy fixes as yaml, and also on schedule by @wdconinc in #1874
- build(deps): bump dawidd6/action-download-artifact from 9 to 10 by @dependabot in #1891
- Make 10x100 CI run use epic_craterlake_10x100.xml by @simonge in #1895
🔩 Other Changes
- feat: remove vestigial JANA logger by @wdconinc in #1847
- fix: rm undefined collection DIRCPID by @wdconinc in #1893
- Move reco plugin detector constants into algorithm by @simonge in #1897
- MatchClusters: do not assign PDG code to trackless EM clusters by @veprbl in #1903
Full Changelog: v1.25.0...v1.26.0
v1.25.0
What's Changed
🕸️ Tracking
- fix: workaround m_particleHypothesis in CKFTracking for acts-36.0.0 too by @wdconinc in #1796
- run clang-format in CI by @veprbl in #1692
- fix: use clang-format rev: v16.0.6 by @wdconinc in #1800
- fix: iwyu treewide after fixing iwyu.imp refs by @wdconinc in #1813
- Use pixel-style MPDG readout for tracking until efficiency issues are resolved by @bschmookler in #1819
- Add Lowq2 track association by @simonge in #1775
- fix: use range-for by reference when possible by @wdconinc in #1830
- fix: virtual destructor for ActsGeometryProvider to avoid warning by @wdconinc in #1838
- fix: a few loose ends to avoid compiler warnings by @wdconinc in #1840
- fix: remove unused variables by @wdconinc in #1828
- fix: avoid pessimizing moves where RVO copy elision by @wdconinc in #1829
- fix: avoid signed/unsigned comparisons by @wdconinc in #1831
- fix: use consistent ChangeRun and Process arguments by @wdconinc in #1827
- fix: comment unused arguments and mark maybe_unused by @wdconinc in #1835
- feat(ci): compile with -Werror -Wall -Wextra by @wdconinc in #1826
🪪 Particle identification
- Bug fix on SiliconPulseDiscretization giving nan values sometimes. by @ssedd1123 in #1804
- feat: separate PhotoMultiplierHitDigi readout/detector/plugin names by @wdconinc in #1807
- fix: rm clang-format off pragmas where gratuitous by @wdconinc in #1817
- fix: improve const-correctness in RichGeo service by @wdconinc in #1816
- fix: remaining signed comparisons and unused variable warnings by @wdconinc in #1844
- feat: use algorithms logger service in IrtCherenkovParticleID by @wdconinc in #1839
- fix: BTOF uses TOFBarrelCombinedPulses by @wdconinc in #1859
🚿 Calorimetry
- fix: correct CalorimeterClusterRecoCoG inputs by EDM4eic version by @wdconinc in #1788
- feat: shortcut lambda if float in EvaluatorSvc by @wdconinc in #1815
- fix: use GeoSvc in TrackClusterMerger instead of init(ptr) by @wdconinc in #1832
- fix: use std::log to avoid confusion with logger functions by @wdconinc in #1842
⏪ Far Backward
- fix: hide OMD, RPOTS, LOWQ2 errors for single particle simulations by @wdconinc in #1716
- fix: slight modification of maximum weight with unsigned indices by @wdconinc in #1837
- fix: avoid getMCParticle deprecation warning in FarDetectorLinearTracking by @wdconinc in #1825
- fix: ensure algorithms satisfy const process function by @wdconinc in #1833
- Use lowq2 track associations by @simonge in #1777
- Restore TaggerTrackerRecHits by @simonge in #1792
⏩ Far Forward
- MatrixTransferStatic: move matrix configurations to config, implement OMD config for 130 GeV by @veprbl in #1780
- fix: avoid geoManager->GetCurrentMatrix in LGADChargeSharing::_global2Local by @wdconinc in #1811
⚙️ Infrastructure
- labeler.yml: add few more paths by @veprbl in #1784
- Combine pulses in the same CellID by @simonge in #1762
- chore(ci): remove mmap rnd_bits workaround by @wdconinc in #1786
- linux-eic-shell.yml: add CXX setting for 25.01.1-stable build by @veprbl in #1791
- feat: use spdlog mapped diagnostic context to store event number by @wdconinc in #1767
- add .git-blame-ignore-revs by @veprbl in #1798
- fix: iwyu.imp: /usr/local -> /opt/local by @wdconinc in #1805
- fix(ci): list more open PRs in GitHub API call by @wdconinc in #1818
- fix(ci): leak; hide first fix later by @wdconinc in #1846
- fix(ci): remove CC, only use CXX by @wdconinc in #1845
- chore(ci): unpin upload-artifact/merge by @wdconinc in #1849
- feat(ci): use reusable workflow call for list-open-prs by @wdconinc in #1850
- fix: rm unused vars in src/scripts/CMakeLists.txt by @wdconinc in #1851
- fix(ci): LD_LIBRARY_PATH should be $PWD/install/lib by @wdconinc in #1857
- fix(ci): prevent uncontrolled ccache growth with 7d eviction by @wdconinc in #1855
🔩 Other Changes
- fix: if no hadronic final state, return instead of throw by @wdconinc in #1795
- fix:
ReconstructedChargedParticleIDs
(unknown) ->ReconstructedChargedRealPIDParticleIDs
in output collections by @wdconinc in #1803 - Adopt edm4eic::SimPulse in for current pulse algorithms by @simonge in #1810
- fix: remove LD_LIBRARY_PATH modifications from eicrecon-this.sh.in by @wdconinc in #1004
- fix: also store Forward{RomanPot,OffMTracker}RawHits by @wdconinc in #1812
- rm src/benchmarks/reconstruction/tracking_efficiency/scripts by @veprbl in #1823
- fix: mark static RichGeo functions as maybe_unused by @wdconinc in #1834
- fix: check scattered electron size in InclusiveKinematics* by @wdconinc in #1814
- fix: correct class initializer ordering by @wdconinc in #1836
- Make CollectionCollector collections optional by @simonge in #1843
- feat: add ActsTrajectoriesMerger by @wdconinc in #1824
- fix: check size before indexing in InclusiveKinematicsESigma by @wdconinc in #1860
Full Changelog: v1.24.2...v1.25.0
v1.24.2
What's Changed
🕸️ Tracking
- [Backport v1.24] Use pixel-style MPDG readout for tracking until efficiency issues are resolved by @bschmookler in #1820
Full Changelog: v1.24.1...v1.24.2