Conversation
veprbl
force-pushed
the
pr/minor_fixes
branch
from
7cf7f55 to
ff6e590
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce the number of generated events in the zdc_sigma benchmark and standardize the use of snakemake flags across config files. However, there is a critical bug in the implementation.
- Reduced N_EVENTS in zdc_sigma from 100,000 to 200
- Replaced hardcoded
--cacheflag with$SNAKEMAKE_FLAGSvariable in tracking_performances and lfhcal configs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmarks/zdc_sigma/Snakefile | Reduces N_EVENTS from 100,000 to 200, but this creates a critical mismatch with the simulation step requirements |
| benchmarks/tracking_performances/config.yml | Replaces hardcoded --cache with $SNAKEMAKE_FLAGS variable for consistency |
| benchmarks/lfhcal/config.yml | Replaces hardcoded --cache with $SNAKEMAKE_FLAGS variable for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veprbl
force-pushed
the
pr/minor_fixes
branch
from
cdebf7a to
f0fba0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.