feat(ci): test package builds more thoroughly#837
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive CI/CD pipeline for the eic-spack repository, adding automated testing, style checking, and auditing capabilities. The implementation creates a test environment specification and two GitHub Actions workflows to ensure code quality and package buildability.
Changes:
- Adds a new Spack environment configuration for EIC packages with key detector, simulation, and analysis tools
- Implements a style and audit workflow that automatically checks code style, runs Spack audits, and can create PRs with automated style fixes
- Implements a build and test workflow that detects changed packages, builds them individually, and tests a complete environment
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| environments/eic/spack.yaml | Defines a comprehensive test environment with core EIC packages including epic, eicrecon, dd4hep, and supporting libraries |
| .github/workflows/style_and_audit.yml | Adds automated style checking, audit validation, and PR creation for style fixes |
| .github/workflows/build_and_test.yml | Implements change detection, individual package builds, and full environment testing with buildcache support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
commented
Feb 19, 2026
wdconinc
commented
Feb 19, 2026
wdconinc
commented
Feb 19, 2026
wdconinc
commented
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
ci-build-test
branch
from
e6348de to
0e5b926
Compare
wdconinc
added a commit
that referenced
this pull request
Feb 20, 2026
## 🤖 Automated Style Fixes This PR applies automated style fixes for #837. ### Changes Applied - `spack style --fix` formatting - Ensures compliance with Spack style guidelines ### Original PR - **Number**: #837 - **Branch**: `ci-build-test` - **Title**: feat(ci): test package builds more thoroughly ### How to Use 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin ci-build-test-style-fix git merge origin/ci-build-test-style-fix ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/22231572429).* Co-authored-by: wdconinc <[email protected]>
wdconinc
commented
Feb 20, 2026
wdconinc
commented
Feb 21, 2026
Contributor
wdconinc
added a commit
that referenced
this pull request
Feb 21, 2026
This PR applies automated style fixes for #837. - `spack style --fix` formatting - Ensures compliance with Spack style guidelines - **Number**: #837 - **Branch**: `ci-build-test` - **Title**: feat(ci): test package builds more thoroughly 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin ci-build-test-style-fix git merge origin/ci-build-test-style-fix ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/22231572429).* Co-authored-by: wdconinc <[email protected]>
wdconinc
force-pushed
the
ci-build-test
branch
from
c83f999 to
a043565
Compare
wdconinc
commented
Feb 21, 2026
wdconinc
commented
Feb 21, 2026
wdconinc
added a commit
that referenced
this pull request
Feb 21, 2026
This PR applies automated style fixes for #837. - `spack style --fix` formatting - Ensures compliance with Spack style guidelines - **Number**: #837 - **Branch**: `ci-build-test` - **Title**: feat(ci): test package builds more thoroughly 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin ci-build-test-style-fix git merge origin/ci-build-test-style-fix ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/22231572429).* Co-authored-by: wdconinc <[email protected]>
wdconinc
force-pushed
the
ci-build-test
branch
from
7f55011 to
5fe46c4
Compare
wdconinc
commented
Feb 21, 2026
wdconinc
commented
Feb 22, 2026
wdconinc
commented
Feb 22, 2026
wdconinc
commented
Feb 22, 2026
wdconinc
commented
Feb 22, 2026
Adds spack configuration files under `config/ci/` to enable the
`develop` buildcache and tune concretization for CI builds.
- **`config/ci/mirrors.yaml`** — registers the develop buildcache
mirror:
```yaml
mirrors:
develop:
url: https://binaries.spack.io/develop
signed: true
```
- **`config/ci/concretizer.yaml`** — reuses prebuilt binaries for
dependencies but not roots, avoiding stale root rebuilds while still
benefiting from cached deps:
```yaml
concretizer:
reuse:
roots: false
dependencies: true
```
<!-- START COPILOT CODING AGENT TIPS -->
---
🔒 GitHub Advanced Security automatically protects Copilot coding agent
pull requests. You can protect all pull requests by enabling Advanced
Security for your repositories. [Learn more about Advanced
Security.](https://gh.io/cca-advanced-security)
---------
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: wdconinc <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
This PR applies automated style fixes for #837. - `spack style --fix` formatting - Ensures compliance with Spack style guidelines - **Number**: #837 - **Branch**: `ci-build-test` - **Title**: feat(ci): test package builds more thoroughly 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin ci-build-test-style-fix git merge origin/ci-build-test-style-fix ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/22280755533).* Co-authored-by: wdconinc <[email protected]>
This PR applies automated style fixes for #837. - `spack style --fix` formatting - Ensures compliance with Spack style guidelines - **Number**: #837 - **Branch**: `ci-build-test` - **Title**: feat(ci): test package builds more thoroughly 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin ci-build-test-style-fix git merge origin/ci-build-test-style-fix ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/22281480108).* Co-authored-by: wdconinc <[email protected]>
Fix typo in dependency type for 'cxx'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds a CI build, test, audit, style pipeline. Test environment in
environments/eic/spack.yaml, but individual packages are also built.Todo: