Remove acts identification variant and drop packages requiring acts ≤37#852
Open
Remove acts identification variant and drop packages requiring acts ≤37#852
identification variant and drop packages requiring acts ≤37#852Conversation
… on acts ≤37 Co-authored-by: wdconinc <[email protected]>
Copilot
AI
changed the title
[WIP] Remove identification variant in acts dependencies
Remove acts Mar 5, 2026
identification variant and drop packages requiring acts ≤37
wdconinc
reviewed
Mar 5, 2026
wdconinc
reviewed
Mar 5, 2026
wdconinc
requested changes
Mar 5, 2026
… variant; remove eicrecon ≤1.15, juggler ≤14.1 Co-authored-by: wdconinc <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the EIC Spack overlay with upstream Spack’s removal of the acts identification variant and dropping of Acts versions ≤37 by removing incompatible package versions and eliminating dependencies that required the identification plugin.
Changes:
- Remove
athena_eicandescalatepackages (identification-plugin dependent). - Update
ejanato drop theactsvariant/dependency and related CMake handling. - Cull old
juggler/eicreconversions and simplify dependency constraints for the remaining supported versions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spack_repo/eic/packages/juggler/package.py | Drops pre-14.2 versions and removes +identification usage; simplifies deps for remaining releases. |
| spack_repo/eic/packages/escalate/package.py | Removes the escalate bundle package (Acts identification-plugin dependent). |
| spack_repo/eic/packages/ejana/package.py | Removes the acts variant and associated dependency/CMake handling. |
| spack_repo/eic/packages/eicrecon/package.py | Drops versions ≤1.15 and makes Acts/json(+dd4hep) and other deps unconditional for remaining versions. |
| spack_repo/eic/packages/athena_eic/package.py | Removes athena_eic package (direct identification-plugin dependency). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream spack removed the
identificationvariant fromacts(existed only through v34) and dropped acts versions ≤37. This removes+identificationfrom non-version-pinned acts dependencies, culls package versions that can only resolve to acts ≤37, and removes packages that fundamentally depend on theidentificationplugin.Package removals (use identification plugin)
athena_eic— removed entirely (directly uses theidentificationplugin)escalate— removed entirely (ejana +actsis no longer possible)Package changes (identification plugin used in all versions)
ejana— removed theactsvariant entirely (all versions use the identification plugin);ejanano longer depends onactsat all. Removed associatedcmake_argshandling.Version removals (acts identification plugin required)
jugglereicreconescalateDirective cleanup
juggler: removedcxxstdvariant (was only applicable for ≤11), removed stale version-conditional deps (acts@:14.1, gaudi, podio, edm4hep, edm4eic, k4fwcore, k4actstracking, algorithms, eicrecon) that became unconditional for remaining versionseicrecon: updated acts dep to unconditionalacts +dd4hep +json+acts@30:; simplified all version-conditional deps that are always true for remaining versions (≥1.16)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.