Skip to content

Remove acts identification variant and drop packages requiring acts ≤37#852

Open
Copilot wants to merge 4 commits intodevelopfrom
copilot/remove-identification-variant-acts
Open

Remove acts identification variant and drop packages requiring acts ≤37#852
Copilot wants to merge 4 commits intodevelopfrom
copilot/remove-identification-variant-acts

Conversation

Copy link
Contributor

Copilot AI commented Mar 5, 2026

Upstream spack removed the identification variant from acts (existed only through v34) and dropped acts versions ≤37. This removes +identification from non-version-pinned acts dependencies, culls package versions that can only resolve to acts ≤37, and removes packages that fundamentally depend on the identification plugin.

Package removals (use identification plugin)

  • athena_eic — removed entirely (directly uses the identification plugin)
  • escalate — removed entirely (ejana +acts is no longer possible)

Package changes (identification plugin used in all versions)

  • ejana — removed the acts variant entirely (all versions use the identification plugin); ejana no longer depends on acts at all. Removed associated cmake_args handling.

Version removals (acts identification plugin required)

Package Removed versions Reason
juggler 1.5.0–14.1.0 Use Acts identification plugin
eicrecon 0.1.0–1.15.0 Use Acts identification plugin
escalate 1.0.1, 1.1.0 (package removed entirely)

Directive cleanup

  • juggler: removed cxxstd variant (was only applicable for ≤11), removed stale version-conditional deps (acts@:14.1, gaudi, podio, edm4hep, edm4eic, k4fwcore, k4actstracking, algorithms, eicrecon) that became unconditional for remaining versions
  • eicrecon: updated acts dep to unconditional acts +dd4hep +json + acts@30:; simplified all version-conditional deps that are always true for remaining versions (≥1.16)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Remove identification variant in acts dependencies Remove acts identification variant and drop packages requiring acts ≤37 Mar 5, 2026
… variant; remove eicrecon ≤1.15, juggler ≤14.1

Co-authored-by: wdconinc <[email protected]>
@wdconinc wdconinc marked this pull request as ready for review March 5, 2026 22:11
Copilot AI review requested due to automatic review settings March 5, 2026 22:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the EIC Spack overlay with upstream Spack’s removal of the acts identification variant and dropping of Acts versions ≤37 by removing incompatible package versions and eliminating dependencies that required the identification plugin.

Changes:

  • Remove athena_eic and escalate packages (identification-plugin dependent).
  • Update ejana to drop the acts variant/dependency and related CMake handling.
  • Cull old juggler/eicrecon versions and simplify dependency constraints for the remaining supported versions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
spack_repo/eic/packages/juggler/package.py Drops pre-14.2 versions and removes +identification usage; simplifies deps for remaining releases.
spack_repo/eic/packages/escalate/package.py Removes the escalate bundle package (Acts identification-plugin dependent).
spack_repo/eic/packages/ejana/package.py Removes the acts variant and associated dependency/CMake handling.
spack_repo/eic/packages/eicrecon/package.py Drops versions ≤1.15 and makes Acts/json(+dd4hep) and other deps unconditional for remaining versions.
spack_repo/eic/packages/athena_eic/package.py Removes athena_eic package (direct identification-plugin dependency).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc requested a review from veprbl March 5, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants