fix: dRICH sensor material should not be AirOptical
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial-should-not-be-airoptical
|
@c-dilks @chchatte92 Is this issue solved? When this file moved, git didn't understand that and marked it as deleted, and the new one is treated as a different one, so you can't easily compare/merge. Also, the current one looks to my eye substantially different, so I can't easily identify which instance of AirOptical needs (or needed) to be changed. |
|
@chchatte92 We are tagging a new release for the February campaign soon. Is there anyone working on this PR? Is it expected to be ready for February release? |
Dear Sakib, I will get back to you soon (either later today or in the weekends) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Close #18
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No