dRICH large sensor for focal point region studies #351
Conversation
… studies of focal point positions). Also added option to draw calcualted focal points from local text file (generated with script in drich-dev)
…tor of dRICH, and one to draw calculated focal points alongside normal sensors tiled on sphere
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: forward
|
Looks good to me. Where should we store your code to calculate the focal points? Here or in |
|
The focal point determination script is already in drich-dev (PR #55 in drich-dev), so I would say there makes more sense. |
|
@cpecar I updated this branch w.r.t. |
…le in compact file to store location of focal point position file
for more information, see https://pre-commit.ci
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
for more information, see https://pre-commit.ci
src/DRICH_geo.cpp
Outdated
| case 5: | ||
| vesselSolid = vesselBox; | ||
| gasvolSolid = gasvolBox; | ||
| break; | ||
| case 2: | ||
| vesselSolid = vesselBox; | ||
| gasvolSolid = gasvolUnion; |
There was a problem hiding this comment.
Add default case (even though already handled, but code above may change and leave this as the first switch).
| } // end if(debugOpticsMode != 4) | ||
|
|
||
| // large sensor placement (for focal point testing): | ||
| if (debugOpticsMode == 4){ |
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
|
Is this branch still under development? Can you rebase, fix merge conflicts, and comment when it's ready? |
Adding @chchatte92. Can you pick this up if needed, or close if not needed? |
|
Sorry, I should have finished this a while ago and the PR has fallen behind a a good bit in terms of how the sensors are now defined. I’ll wait for word from Chandra on if this would still be a useful feature and if so I’ll bring it up to date and finalize it. |
|
@cpecar @chchatte92 We are tagging a new release for February simulation campaign? What's the status of this PR? Is it supposed to be merged or no? |
Briefly, what does this PR introduce?
Adds two new optics debugging mode for dRICH:
4 - creates large photosensor instead of default dRICH sensors, designed to catch all possible reflected photons. This is currently used with test 12 / 14 in drich-devs, throwing parallel beams of photons in order to determine the focal region of the dRICH optics.
5 - from a local text file, creates representations of the calculated focal points from mode 4 and a script in drich-devs, and also creates default dRICH sensors to visually compare calculated focal point to sensor position.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.