-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual mirror implementation #380
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
… dual_mirror_implementation
for more information, see https://pre-commit.ci
@c-dilks |
The validation method is adopted as the following
|
@chchatte92 What's the status of this PR? Does this need to be merged for the February simulation campaign? |
Briefly, what does this PR introduce?
This PR tries to implement the two mirrors of different radii to handle the spherical aberration and improve the Cherenkov angular resolution.
What kind of change does this PR introduce?
To be addressed issues
Please check if this PR fulfills the following:
This is a draft pull and @c-dilks is asked to review the changes
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No