Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual mirror implementation #380

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

chchatte92
Copy link
Member

@chchatte92 chchatte92 commented Feb 28, 2023

Briefly, what does this PR introduce?

This PR tries to implement the two mirrors of different radii to handle the spherical aberration and improve the Cherenkov angular resolution.

What kind of change does this PR introduce?

  • The code implements dual mirror for the dRICH. It uses the box method to implement two mirrors. The 'Half space' method is still not working.
  • The upper mirror is implemented with a smaller radius, so that the photons dive into the sensor surface.

To be addressed issues

  • Many more deflected photons
  • Sensor plane optimization

Please check if this PR fulfills the following:

This is a draft pull and @c-dilks is asked to review the changes

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@chchatte92 chchatte92 self-assigned this Feb 28, 2023
@github-actions github-actions bot added topic: forward Positive-rapidity detectors (hadron-going side) topic: PID Particle identification labels Feb 28, 2023
@c-dilks c-dilks linked an issue Feb 28, 2023 that may be closed by this pull request
@chchatte92
Copy link
Member Author

@c-dilks
I checked the conflicts; there are two conflicts wrt main. The first one related to the mirror description
and the second one is related to the sensor X,Y,Z and radius. Now the first one is obvious. We need to deal a bit with the second one. Maybe we can have a discussion with Marco and Luca. The spherical patch, I have however kept the same.

@chchatte92
Copy link
Member Author

chchatte92 commented Apr 19, 2023

Here are the ring images with the current configuration;
dual mirror:
Screenshot from 2023-04-18 23-22-10
single mirror:
Screenshot from 2023-04-19 11-16-12

@chchatte92
Copy link
Member Author

The photons on the sensor surface:
Screenshot from 2023-04-19 11-13-27

@chchatte92
Copy link
Member Author

chchatte92 commented Apr 19, 2023

The photons hits not very clean (5 tracks in 24 phi bins and 3 eta bins)
dual mirror:
image
Chris' PR:
image

To be addressed

@chchatte92
Copy link
Member Author

chchatte92 commented Apr 25, 2023

The validation method is adopted as the following

  • To use single mirror configuration each time with one of the two mirrors' parameters.
  • Extract the resolution using single particles at a fixed eta and uniform phi.

@c-dilks c-dilks mentioned this pull request Dec 13, 2023
5 tasks
@rahmans1
Copy link
Contributor

rahmans1 commented Feb 7, 2024

@chchatte92 What's the status of this PR? Does this need to be merged for the February simulation campaign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: forward Positive-rapidity detectors (hadron-going side) topic: PID Particle identification
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

dRICH: implement dual mirrors
3 participants