-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export simulation geometry to CAD models (STEP) #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
topic: infrastructure
Regarding build system, CI, CD
label
Mar 15, 2024
This now works "well enough" for merging: imported y-up and created a back view with left view section drawing. As I wrote, caveats:
|
veprbl
reviewed
Mar 24, 2024
Co-authored-by: Dmitry Kalinkin <[email protected]>
veprbl
approved these changes
Mar 24, 2024
wdconinc
added a commit
that referenced
this pull request
Mar 25, 2024
### Briefly, what does this PR introduce? This PR exports the geometry to STEP files for CAD import and dimensioning. There are no real settings to tweak, but to increase the level at which volumes are exported, hints can be added to the yaml file. Detectors can also be removed (currently only the ACTS subassemblies are removed since they don't do anything). There are 'issues' that need to be addressed, but they have to be addressed in npsim: - units are off (npdet_to_step use the cm value from TGeo and writes them as inch values in STEP) eic/npsim#20, - some shapes cannot be exported; not sure yet which ones and it makes more sense to bypass them in npsim eic/npsim#21. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR exports the geometry to STEP files for CAD import and dimensioning. There are no real settings to tweak, but to increase the level at which volumes are exported, hints can be added to the yaml file. Detectors can also be removed (currently only the ACTS subassemblies are removed since they don't do anything).
There are 'issues' that need to be addressed, but they have to be addressed in npsim:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.