Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEEMCal geometry update #704

Merged
merged 30 commits into from
Jun 4, 2024
Merged

EEEMCal geometry update #704

merged 30 commits into from
Jun 4, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 11, 2024 •
edited
Loading

Briefly, what does this PR introduce?

Updates:

  • Change thickness of outer support volume
  • Removing steel from filling gaps between cells and outer support
  • New inner support collar
  • Remove copper between inner support and cells
  • Adjust cell width
  • Adjust intercell wrappers thicknesses

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@github-actions github-actions bot added topic: backward Negative-rapidity detectors (electron-going side) topic: calorimetry labels Apr 11, 2024
@veprbl veprbl added this to the 24.05.0 milestone Apr 11, 2024
@github-actions github-actions bot added the topic: barrel Mid-rapidity detectors label Apr 26, 2024
@veprbl veprbl force-pushed the pr/eeemcal_new_inner_support branch from 4654ab4 to d3e52aa Compare April 26, 2024 03:04
@veprbl veprbl modified the milestones: 24.05.0, 24.06.0 May 7, 2024
@veprbl veprbl changed the title EEEMCal new inner support EEEMCal new inner and outer supports May 23, 2024
@veprbl veprbl changed the title EEEMCal new inner and outer supports EEEMCal geometry update May 28, 2024
@veprbl veprbl marked this pull request as ready for review May 29, 2024 12:36
@veprbl veprbl requested review from kkauder and Chao1009 May 30, 2024 01:08
@veprbl
Copy link
Member Author

veprbl commented May 30, 2024

Comparison of this geometry (salmon) to CAD drawing provided (emerald):
image
Funky irregular rows in the middle are not implemented on purpose.

@veprbl veprbl requested a review from wdconinc May 31, 2024 19:37
@veprbl
Copy link
Member Author

veprbl commented Jun 2, 2024

As we are finalizing 24.06.0 geometry, this could use a review.

@wdconinc
Copy link
Contributor

wdconinc commented Jun 2, 2024

As we are finalizing 24.06.0 geometry, this could use a review.

Started looking but it's a fairly sizeable changeset.

wdconinc
wdconinc approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Optional comment.

src/HomogeneousCalorimeter_geo.cpp Show resolved Hide resolved
@veprbl veprbl enabled auto-merge June 3, 2024 23:45
@veprbl veprbl added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 3f457b7 Jun 4, 2024
113 checks passed
@veprbl veprbl deleted the pr/eeemcal_new_inner_support branch June 4, 2024 01:48
@veprbl veprbl mentioned this pull request Jun 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 20, 2024
@veprbl
EEEMCal: reparametrize inner collar in terms of proton ring x offest (#…
3c3c5d5 
…742)

Implements implicit suggestion from
#704 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc approved these changes

@kkauder kkauder Awaiting requested review from kkauder

@Chao1009 Chao1009 Awaiting requested review from Chao1009

Assignees
No one assigned
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: barrel Mid-rapidity detectors topic: calorimetry
Projects
None yet
Milestone
24.06.0
Development

Successfully merging this pull request may close these issues.
2 participants
@veprbl @wdconinc